John/adjust camera to viewport #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So that textures don't have to be interpolated. Modified example start coords for better visual comparison.
In order to keep tile textures 1:1 with viewport pixels
Also updated comments slightly
|
This is too aggressive, so let's drop it. Nonetheless, I still want to add an orthographic mode, so that we can reproduce the full image fidelity of each map tile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch updates vtkMap to adjust the camera view angle based on the size of the viewport (specifically, the height of the viewport). The current code uses a constant 30 degrees, which is the vtk default. The purpose of this branch is to maintain a 1:1 ratio between the viewport pixel size and the tile pixel size.
By keeping the pixel sizes in sync, texture interpolation is not needed and no longer enabled. The result is a slight improvement in image sharpness, particularly with text/labels.
I am not 100% sure we want to merge these changes, however, as it will introduce perspective distortion of 3-D data (another reason to have 2 renderers, I suppose...)