Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tlg1181.tlg001 from Schiefsky's file to FirstIK-grc #1945

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

rebeccadraughon
Copy link
Collaborator

Changed tlg1181.tlg001 from Schiefsky's list to DDD compliance; added to First1K-grc.

Copy link
Contributor

@sonofmun sonofmun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes need to be made to the file. Plus there is no __cts__.xml metadata file for either the author or the work. Check how these look for the other authors and works and customize them from there.

<p>Text encoded in accordance with the latest EpiDoc standards</p>
<refsDecl n="CTS">
<cRefPattern matchPattern="(.+).(.+)" n="section"
replacementPattern="#xpath(/tei:TEI/tei:text/tei:body/tei:div/tei:div[@n='$1']/tei:div[@n='$2'])"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is no second level of the citation scheme here, only "chapter"s. So the "section" cRefPattern should be deleted.

<teiHeader xml:lang="eng">
<fileDesc>
<titleStmt>
<title>Aristarchus of Samos, the Ancient Copernicus: a History of Greek Astronomy to
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <title> element in the <titleStmt> should be the title of the work, not the title of the volume. According to the TLG, the title of this work is "De magnitudinibus et distantiis solis et lunae". Make sure also to put an xml:lang="lat" attribute on the <title> element.

</titleStmt>
<publicationStmt>
<authority>Harvard College Library</authority>
<idno type="tlg1181.tlg001.1st1K-grc.xml"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The type attribute here should be "filename" and then the filename itself should be in the text of the element, i.e., <idno type="filename">tlg1181.tlg001.1st1K-grc1.xml</idno>.

<name>Sir Thomas Heath</name>
</persName>
</editor>
<author ref="urn:cts:greekLit:tlg1181.tlg001">Aristarchus</author>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The URN for the author should not include the "tlg001". It should only be "urn:cts:greekLit:tlg1181".

</imprint>
<biblScope unit="volume"/>
</monogr>
<ref target="https://archive.org/details/aristarchusofsam00heatuoft"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The <ref> element should contain a text naming where this came from, i.e., <ref target="https://archive.org/details/aristarchusofsam00heatuoft">The Internet Archive</ref>

@sonofmun
Copy link
Contributor

sonofmun commented Dec 8, 2017

There are some changes that need to be made besides those in the XML file.

  1. There needs to be a sub-folder for the work. So the TEI-XML file should be in /data/tlg1181/tlg001
  2. In the author folder (i.e., /data/tlg1181) there needs to be a __cts__.xml file with the metadata for the author. Check, e.g., https://github.com/OpenGreekAndLatin/First1KGreek/blob/master/data/tlg0015/__cts__.xml for an example.
  3. In the work-level folder (i.e., /data/tlg1181/tlg001), there also needs to be a __cts__.xml metadata file with the information about the work and each of the editions. See https://github.com/OpenGreekAndLatin/First1KGreek/blob/master/data/tlg0015/tlg001/__cts__.xml for an example.

@lcerrato lcerrato added the Legacy Older OGL work label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Legacy Older OGL work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants