Update tlg0559_cts_.xml #2036
Merged
Update tlg0559_cts_.xml #2036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added in Latin variant (in one header) and in German name (because its in all the scans and looks cool! :P )
planatheisa
reviewed
Feb 25, 2018
data/tlg0559/__cts__.xml
Outdated
| @@ -1,3 +1,6 @@ | |||
| <ti:textgroup xmlns:ti="http://chs.harvard.edu/xmlns/cts" urn="urn:cts:greekLit:tlg0559"> | |||
| <ti:groupname xml:lang="eng">Hero of Alexandria</ti:groupname> | |||
| <ti:groupname xml:lang="lat">Heronis Alexandrini</ti:groupname> | |||
| <ti:groupname xml:lang="deu">Herons von Alexandreia</ti:groupname> | |||
There was a problem hiding this comment.
Where in the scan does it say that? Wikipedia gives the German name as "Heron von Alexandria".
There was a problem hiding this comment.
Just bumping this comment @AlisonBabeu
There was a problem hiding this comment.
Whoops, sorry for missing this for so long, must have made a typo adding in the German name. The Latin name variant shows up in several of the <biblstruct> sections, like here:
I'll fix the German and you can do as you like with the Latin! :)
Fixing typo in German name variant.
planatheisa
approved these changes
Mar 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in Latin variant (in one header) and in German name (because its in all the scans and looks cool! :P )