Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tlg2042.tlg058.1st1K-grc1.xml #2040

Merged
merged 4 commits into from
Mar 8, 2018
Merged

Added tlg2042.tlg058.1st1K-grc1.xml #2040

merged 4 commits into from
Mar 8, 2018

Conversation

sonofmun
Copy link
Contributor

Origen Selecta in Psalmos

Origen Selecta in Psalmos
@ghost
Copy link

ghost commented Feb 28, 2018

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +1622
texts_passing +1
texts_total +1

Words

Changed Status
grc +102752

Units

Changed Status
./data/tlg2042/tlg058/__cts__.xml New
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml New
./data/tlg2042/tlg058/__cts__.xml Passing
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml Passing

Hook UI build recap

@ghost
Copy link

ghost commented Feb 28, 2018

Global

Changed Status
coverage -0.01
metadata_passing 1
metadata_total 1
nodes_count 1622
texts_passing -2
texts_total 1

Words

Changed Status
grc +102752

Units

Changed Status
./data/tlg2042/tlg058/__cts__.xml New
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml New
./data/ggm0001/ggm001/ggm0001.ggm001.1st1K-grc1.xml Failing
./data/heb0001/heb010/heb0001.heb010.1st1K-eng1.xml Failing
./data/stoa0033a/tlg028/stoa0033a.tlg028.1st1K-grc1.xml Failing
./data/tlg2042/tlg058/__cts__.xml Passing
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml Passing

Hook UI build recap

Copy link
Contributor

@planatheisa planatheisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The chapters (or sections) have greek numbers which are off by one to the div number. It might not matter much but I think it would make sense to have the numbers match up.

@sonofmun
Copy link
Contributor Author

sonofmun commented Mar 1, 2018

Good catch. I have updated it and also put in corresp attributes since the chapter parts refer to the biblical text.

@ghost
Copy link

ghost commented Mar 1, 2018

Global

Changed Status
metadata_passing +1
metadata_total +1
nodes_count +1623
texts_passing +1
texts_total +1

Words

Changed Status
grc +102752

Units

Changed Status
./data/tlg2042/tlg058/__cts__.xml New
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml New
./data/tlg2042/tlg058/__cts__.xml Passing
./data/tlg2042/tlg058/tlg2042.tlg058.1st1K-grc1.xml Passing

Hook UI build recap

@planatheisa planatheisa merged commit ce0010c into master Mar 8, 2018
@planatheisa planatheisa deleted the tlg2042.tlg058 branch March 8, 2018 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants