Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tlg0018 eng1 #2726

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Tlg0018 eng1 #2726

wants to merge 2 commits into from

Conversation

gregorycrane
Copy link
Contributor

This is the translation for work 1 of Philo. The comments about the Greek (such as adding the base URN) will be much the same. I should do some more work (such as embedding the notes in their locations better) but this could be serviceable. There are 730,000 words of translation -- a lot to go over. I have compared this text with another OCR-generated version and I think the accuracy is pretty good.

@lcerrato
Copy link
Collaborator

@AlisonBabeu
For header and CTS input as well as catalog new edition work

@lcerrato
Copy link
Collaborator

see also #2725 (not sure of differences between that file and this file here?)

@lcerrato
Copy link
Collaborator

@lcerrato
Copy link
Collaborator

@gregorycrane @AlisonBabeu
I have to pre-submit hours these days so I may not immediately be on this given the schedule here. Thus my fragmented comments on this and the related (?) issue. I'm trying to pull together a bunch of threads in a very hasty way to provide assistance but I have not yet looked carefully at the work.

Alison may want to do a cts/header review at the end of this or provide a header checklist now. (This header is very strange but I have not worked in this translation repo, so that might be because it is from 2014).
Typically when working on a corpus, I do all of the metadata first rather than going back and forth. Where much of these will be from the same print volume, that should be easy.

@AlisonBabeu
Copy link
Collaborator

AlisonBabeu commented May 25, 2023

hi @lcerrato and @gregorycrane I will try to offer some useful comments on the header and cts metadata. And to save some work, rather than creating a catalog_pending issue for each translation I've created one (PerseusDL/catalog_pending#185) for this whole batch to remind to create metadata for them as the work goes along. I've also added various comments on both files that I hope are helpful.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @gregorycrane for these new translations, I would put the English title in the label, so the following:

<ti:label xml:lang="eng">On the Creation of the World</ti:label>

And then for the description we have a standard bibliographic format, such as the following, you would just change volume number, publication year, etc. We don't repeat the work title there.

I'm also happy to make corrections/suggestions as you go along.

<ti:description xml:lang="eng">Philo of Alexandria. The works Philo Judaeus, the contemporary of Josephus, Volume 1. Yonge, Charles Duke, translator. London: George Bell and Sons, 1854.</ti:description>

Also from looking at the volume in the Internet Archive , I think you should have London: Henry G. Bohn, 1854.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set, e.g., for tlg0018.tlg001:

<ti:translation urn="urn:cts:greekLit:tlg0018.tlg001.1st1K-eng1" xml:lang="eng" workUrn="urn:cts:greekLit:tlg0018.tlg001">
<ti:label xml:lang="eng">On the Creation of the World</ti:label>
<ti:description xml:lang="eng">The works of Philo Judaeus, the contemporary of Josephus, volume 1. Yonge, C. D., translator. London: Henry G. Bohn, 1854.</ti:description>

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @gregorycrane when I look at the cts_.xml file itself the translation cts_.xml section still looks the same.

</titleStmt>
<publicationStmt>
<authority>University of Leipzig</authority>
<idno type="filename">philo_1_1854.xml</idno>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here we add the new filename:
tlg0018.tlg001.1st1K-eng1.xml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

<pubPlace>Germany</pubPlace>
</publicationStmt>
<sourceDesc>
<listBibl xml:lang="la">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a default value we've been deleting, and it would be "lat" but of course this information is in English.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of two letter language codes throughout

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they should be fixed.

<monogr>
<editor>
<persName>
<name xml:lang="en">Charles Duke Yonge</name>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can strike "en" here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gone

<name xml:lang="en">Charles Duke Yonge</name>
</persName>
</editor>
<author>Philo Alexandrinus</author>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should change this to Philo Judaeus, we try to be consistent with the author name throughout the files.

</persName>
</editor>
<author>Philo Alexandrinus</author>
<title xml:lang="eng">On the Creation of the World</title>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the structured bibliographic section we no longer include the list of all works, and just include the volume title, so all you would need is:

<title>The works of Philo Judaeus</title>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I spent some time keeping the proper titles in the xml -- and, frankly, I think it a problematic design idea not to have the work title in the xml file. It just means we are dependent on another file for crucial info.

<title xml:lang="eng">On Drunkenness</title>
<title xml:lang="eng">On Sobriety</title>
<imprint>
<publisher>George Bell and Sons</publisher>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the publisher is consistent with the cts_.xml section. I often miss that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bohn now in both

<biblScope unit="volume">1</biblScope>
</monogr>
<ref
target="https://archive.org/details/worksphilojudaeu01philuoft" >Internet Archive</ref>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been updating the links here to go to the exact page a work starts on rather than the top level page so in this case you would change it to:
https://archive.org/details/worksphilojudaeu01philuoft/page/n13/mode/2up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a cool feature. I have the pages in now.

<langUsage>
<language ident="en">English</language>
</langUsage>
</profileDesc>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A change note goes here reflecting the EpiDoc and CTS updating

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. This is where you want your work descriptions.

<revisionDesc> <change when="2023-XX-XX" who="Gregory Crane">Split composite file, cleaned up tagging of notes, and used digital files from CCEL.org to follow the sections as the appear in the David Scholer edition of the Yonge translation. General error correction.</change> </revisionDesc>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be in the right place.

</teiHeader>
<text>
<body>
<div type="translation" n="urn:cts:greekLit:tlg0018.tlg001.1st1K-eng1" xml:lang="eng"><head><title type="main">A TREATISE THE ACCOUNT OF ON OF THE WORLD, THE CREATION AS GIVEN BY MOSES.</title></head>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both head and title are not needed
<head rend="align(center)">


<div type="textpart" subtype="section" n="6">
<p>For as the smallest seal receives imitations of <choice><sic>things or</sic><corr>things of</corr></choice> colossal magnitude when engraved upon it, so perchance in some instances the exceeding beauty of the description of the creation of the world as recorded in the Law, overshadowing with its brilliancy the souls of those who happen to meet with it, will be delivered to a more concise record after these facts have been first premised which it would be improper to pass over in silence.
<milestone unit="chapter" n="2"/></p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not leave these milestones at the end of a section. They should always go with the next container.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ended up going through and fixing these file by file.

</div>

<div type="textpart" subtype="section" n="8">
<p>But Moses, who had early reached the very summits of philosophy, <ref n="2.1"/> and who had learnt from the oracles of God the most numerous and important of the principles of nature, was well aware that it is indispensable that in all existing things there must be an active cause, and a passive subject; and that the active cause is the intellect of the universe, thoroughly unadulterated and thoroughly unmixed, superior to virtue and superior to science, superior even to abstract good or abstract beauty;</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know what the <ref> is here. Perhaps the note? Most notes are inline, and I think if we want them this way, it would be something like xml:id not simply id


<div type="textpart" subtype="section" n="10">
<p>for reason proves that the father and creator has a care for that which has been created; for a father is anxious for the life of his children, and a workman aims at the duration of his works, and employs every device imaginable to
<note n="2.1">This is in accordance with the description of him in the Bible, where he is represented as being learned in all the wisdom of the Egyptians. </note>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that the way this is tagged, this note will appear here, inline, nowhere near the thing it is referencing. Simplest thing to do is move it to where it belongs, and drop the n attribute.

</div>

<div type="textpart" subtype="section" n="12">
<p>But the great Moses, thinking that a thing which has not been uncreated is as alien as possible from that which is visible before our eyes (for everything which is the subject of our ^ senses exists in birth and in changes, and is not always in the same condition), has attributed eternity to that which is invisible and discerned only by our intellect as a kinsman and a brother, while of that which is the object of our external senses he had predicated generation as an appropriate description. Since, then, this world is visible and the object of our external senses, it follows of necessity that it must have been created; on which account it was not without a wise purpose that he recorded its creation, giving a very venerable account of God.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

our ^ senses

the carat is superfluous??


<div type="textpart" subtype="section" n="56">
<p>And how great is the use and how great the advantage derivable from each of the aforesaid things, is plain from their effect. But with a view to a more accurate comprehension of them, it may perhaps not be out of place to trace out the truth in a regular discussion.
Now the whole of time being divided into two portions day and night, the sovereignty of the day the Father has assigned to the Sun, as a mighty monarch: and that of the night he has given to the moon and to the multitude of the other stars.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New paragraph here? Would have to look at print.

</div>

<div type="textpart" subtype="section" n="4">
<p>Accordingly no one, whether poet or historian, could ever give expression in an adequate manner to the beauty of his ideas respecting the creation of the world; for they surpass all the power of language, <choice><sic>and amaze.</sic><corr>and amaze</corr></choice> our hearing, being too great and venerable to be adapted to the senses of any created being.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if the choice tags are needed at all here. If these are just things that match the print, then they are superfluous. I see a lot of common sense corrections.
Corrections to errors in the data capture aren't typically encoded.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point! I have taken them out.

</respStmt>
<respStmt>
<persName>Gregory Crane</persName>
<resp>In 2023, GRC broke the translations up into works, cleaned up tagging of notes, and used digital files from CCEL.org to follow the sections as the appear in the David Scholer edition of the Yonge translation. He corrected many errors in the text but many remain.</resp>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not what goes in the resp tag: it goes in the change tag (see my comment below)--
important because the resp statement is what is in the Scaife sidebar and we use a few predetermined labels for consistency with editors

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Digital Editor is preferred

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As an example, the information here ("Digital conversion" and editing and "CTS conversion") are what is in <resp>
image

<pubPlace>Germany</pubPlace>
</publicationStmt>
<sourceDesc>
<listBibl xml:lang="la">
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of two letter language codes throughout

<langUsage>
<language ident="en">English</language>
</langUsage>
</profileDesc>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See above. This is where you want your work descriptions.

<revisionDesc> <change when="2023-XX-XX" who="Gregory Crane">Split composite file, cleaned up tagging of notes, and used digital files from CCEL.org to follow the sections as the appear in the David Scholer edition of the Yonge translation. General error correction.</change> </revisionDesc>

</encodingDesc>
<profileDesc>
<langUsage>
<language ident="en">English</language>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

en should be eng

</sourceDesc>
</fileDesc>
<encodingDesc>
<p>The following text is encoded in accordance with EpiDoc standards and with the CTS/CITE Architecture.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to indicate that there are errors remaining in the text, you do it here (not in <respStmt>)

Some errors corrected but quality

you can use <correction status="XXX"/> here as well to reflect the state of text correction

@gregorycrane
Copy link
Contributor Author

more on base element https://github.com/OpenGreekAndLatin/First1KGreek/wiki/CTS-URNs:-Using-the-xml:base-attribute-in-CTS-divs

Added this to both Philo and Lucian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants