Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to allow enum expermental features #32

Merged
merged 1 commit into from
Jul 15, 2022
Merged

Update to allow enum expermental features #32

merged 1 commit into from
Jul 15, 2022

Conversation

mbeckerle
Copy link
Collaborator

Change tracking is on in the document. Download and you should be able to see the deltas easily.

@smhdfdl smhdfdl self-requested a review July 15, 2022 09:43
smhdfdl
smhdfdl requested changes Jul 15, 2022
View reviewed changes
Copy link
Contributor

@smhdfdl smhdfdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of typos;

  1. dfdl:element binaryNumberRep=”dfdx:onesComplement” - should be dfdlx
  2. Qname should be QName
  3. (Existing typo) Steven Hanson should be Stephen Hanson
  4. DFDL spec date February 2011 should be 2021

@mbeckerle
Copy link
Collaborator Author

Issues from review have been fixed. Tracked changes all accepted.

@mbeckerle mbeckerle merged commit 43b82d2 into OpenGridForum:master Jul 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smhdfdl smhdfdl smhdfdl requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mbeckerle @smhdfdl