First version of PAS Explanatory Report added #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbeckerle
commented
May 17, 2023
|
@mbeckerle I have added comments to the places I was tagged. |
smhdfdl
reviewed
May 18, 2023
mbeckerle
commented
May 18, 2023
|
Last changes are in. @smhdfdl with an official approval from you on this review I will squash 6 commits to one coherent commit and merge back to the master branch and let others know to submit it. |
smhdfdl
requested changes
May 19, 2023
|
@smhdfdl I believe I fixed these additional issues now. |
This is written in markdown. Review was in OpenGridForum#41
mbeckerle
force-pushed
the
iso-pas-explanatory-report
branch
from
d195256
to
5ec23bf
Compare
mbeckerle
added a commit
to mbeckerle/DFDL
that referenced
this pull request
May 24, 2023
This is written in markdown. Review was in OpenGridForum#41
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in markdown.
Use new line for each new sentence style. Long sentences can have multiple lines, but each new sentence should start on a new line.