Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confirm Ground Pi stops sending "Pings" when Remote Settings Disabled #42

Closed
htcohio opened this issue Feb 25, 2019 · 4 comments
Closed
Assignees
Projects

Comments

@htcohio
Copy link
Collaborator

htcohio commented Feb 25, 2019

It was previously shown that GroundPi continued to send "Pings" to air for remote settings even when "RS timeouts" It would be better if the RS terminates on ground completely when timer is set for RS

@pilotnbr1
Copy link
Collaborator

pilotnbr1 commented Feb 25, 2019

I still don’t understand the functionality of timer.. Is the timer function supposed to kill pings so therefore also kill the ability to establish a connection?

All I really know is we are trying to save cpu on the zero by implementing the timer.

I guess I don’t really understand the whole sequence and flow of data

@htcohio
Copy link
Collaborator Author

htcohio commented Feb 25, 2019 via email

@pilotnbr1 pilotnbr1 added this to To do in Kill Bugs Feb 25, 2019
@user1321 user1321 self-assigned this Feb 26, 2019
@user1321 user1321 moved this from To do to In progress in Kill Bugs Feb 26, 2019
@user1321
Copy link
Collaborator

user1321 commented Feb 26, 2019

Good day.
I added to development branch code that will start "RemoteSetting" only if it enabled (Ground. at Air side it was already implemented).

In case if it enabled with timer:
At air side it will completely turn off after certain amount of time.
At ground side it will stay enabled.. But, as main goal save CPU at air, I think we can close that issue.

@pilotnbr1
Copy link
Collaborator

Thanks for the explanation htcohio and nice fix user1321! Closing issue

Kill Bugs automation moved this from In progress to Done Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Kill Bugs
  
Done
Development

No branches or pull requests

3 participants