Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCQIndexing reduce method size for inlining #1410

Closed
tgd opened this issue Aug 7, 2023 · 0 comments
Closed

SCQIndexing reduce method size for inlining #1410

tgd opened this issue Aug 7, 2023 · 0 comments
Assignees

Comments

@tgd
Copy link
Contributor

tgd commented Aug 7, 2023

In SCQIndexing the methods linearScanByPosition0 and setPositionForSequenceNumber are too large to be inlined with default JVM inlining configuration. The output of JitWatch jarScan is shown below. The last number on each line is the method length - we need to reduce to sub 325.

./jarScan.sh --mode=maxMethodSize --limit=325 ~/m2link/repository/net/openhft/chronicle-queue/5.24ea25-SNAPSHOT/chronicle-queue-5.24ea25-SNAPSHOT.jar | grep SCQ
"net.openhft.chronicle.queue.impl.single","SCQMeta","overrideFrom","T",441
"net.openhft.chronicle.queue.impl.single","SCQIndexing","linearScanByPosition0","net.openhft.chronicle.wire.Wire,long,long,long,boolean",430
"net.openhft.chronicle.queue.impl.single","SCQIndexing","setPositionForSequenceNumber","net.openhft.chronicle.queue.impl.ExcerptContext,long,long",338

In the linked pull request both methods were refactored to bring them down to a shorter size meaning they will now be within the limit to be inlined.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant