New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vive updates #90

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
4 participants
@jsarrett
Contributor

jsarrett commented Apr 17, 2017

add measured distortion coefficients and calculated asymmetric frustums for Vive

@jsarrett jsarrett force-pushed the jsarrett:vive_updates branch from 9a9b718 to efc8400 Apr 18, 2017

@TheOnlyJoey

This comment has been minimized.

Member

TheOnlyJoey commented Aug 21, 2017

The values are still quite blobby, we need either a new unwrap through hugin or convert the coefficient values in the vive json.

@jbkempf

This comment has been minimized.

jbkempf commented Jul 11, 2018

Any news on that?

@TheOnlyJoey

This comment has been minimized.

Member

TheOnlyJoey commented Jul 11, 2018

There has been some extensive research regarding correct lens variables and new methods of calculating distortion coefficients, no new readings have been made for the Vive yet, and the ones in this pull request are not good enough to merge.

@ChristophHaag

This comment has been minimized.

Contributor

ChristophHaag commented Jul 11, 2018

There are also distortion values in the Vive json config that someone could try to convert to OpenHMD/panotools/hugin values. Maybe they use those internally in SteamVR to create their distortion mesh?
Apparently they use a model they name DPOLY3, and apparently there is documentation in the SteamVR HDK on what exactly it is, but maybe it also isn't hard to find out what it is without the documentation.

Example: https://gist.github.com/cnlohr/7cd6bf515ed213a4cd642de4cc195d79#file-hmd_config-json-L417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment