Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set new min date on timeslider #28

Closed
danrademacher opened this issue Oct 10, 2019 · 3 comments
Closed

Set new min date on timeslider #28

danrademacher opened this issue Oct 10, 2019 · 3 comments
Assignees

Comments

@danrademacher
Copy link
Member

In resolving OpenHistoricalMap/ohm-website#39 , we set the new datelimit to 1000 in this commit:
OpenHistoricalMap/ohm-website@6c2d044

Turns out we have stuff from Ancient Rome!

So we need to set an older min-date limit.

Over in https://github.com/OpenHistoricalMap/decimaldate-python, we include an example like this

Convert a ISO-formatted date to a decimal date, accounting for negative years (BCE) and for very large dates (-1000000-01-01).

Any reason not to set our floor at the beginning of recorded history?

@jimmyrocks was there a reason to pick 1000, like you tested other values and they failed? Or just seemed old enough?

@jeffreyameyer
Copy link
Member

@jimmyrocks - any update here?

I need it to go waaaaay back. Thanks!

@danrademacher
Copy link
Member Author

This is a change of a few characters, here:
OpenHistoricalMap/ohm-website@6c2d044

Make 1000 into say -5000, which we know is working on the standalone demo at -4000:
https://openhistoricalmap.github.io/openhistoricaltiles/leaflet-control-mbgltimeslider/demo/#14.600/40.80623/-73.91894/1920,-4000-2018

But we need to sort out Github repo access before we can change again

@jeffreyameyer jeffreyameyer transferred this issue from another repository Jun 9, 2020
@danrademacher
Copy link
Member Author

Currently -4000.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants