Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Month and day clear when entering era first time on iD #737

Closed
danrademacher opened this issue Apr 5, 2024 · 2 comments
Closed

Month and day clear when entering era first time on iD #737

danrademacher opened this issue Apr 5, 2024 · 2 comments
Assignees
Labels
bug Something isn't working ID

Comments

@danrademacher
Copy link
Member

From #663:

🔴 The Start Date and End Date do not allow adding month and day, the entered values are cleaned when clicking out the field

@1ec5 asks:

I wonder if this is related to openstreetmap/iD#10145. Have we pulled in the fix in openstreetmap/iD#10151?

This is only on staging.

note that this appears to happen upon selecting AD/BC the first time I am editing the field:

Screen.Recording.2024-04-05.at.3.14.43.PM.480p.mov
@danrademacher danrademacher added bug Something isn't working ID labels Apr 5, 2024
@danrademacher danrademacher mentioned this issue Apr 5, 2024
21 tasks
@danrademacher
Copy link
Member Author

@erictheise any update on this from your efforts on Friday?

@erictheise
Copy link
Member

I'm beginning to suspect this was introduced with OpenHistoricalMap/iD#193. start_date only has the year component by the time it returns from field.js which is what resets the input fields for month and day.

erictheise added a commit to OpenHistoricalMap/iD that referenced this issue Apr 10, 2024
erictheise added a commit to OpenHistoricalMap/iD that referenced this issue Apr 10, 2024
erictheise added a commit to OpenHistoricalMap/ohm-website that referenced this issue Apr 10, 2024
erictheise added a commit to OpenHistoricalMap/ohm-website that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ID
Projects
Development

No branches or pull requests

2 participants