Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negative year date functions update #246

Merged
merged 2 commits into from
May 16, 2024
Merged

Negative year date functions update #246

merged 2 commits into from
May 16, 2024

Conversation

danrademacher
Copy link
Member

@danrademacher
Copy link
Member Author

@Rub21 this is the PR with the updated date functions.

The change in teh date functions themselves is in this commit. It's a bit convoluted, so I would say we deploy this to staging, make sure the database is using it, then GreenInfo can test on staging with some specific cases to be sure it is working as expected.

So I think the main work here for you would be to make sure we can repopulate the decimaldate in the tiles based on these revised functions once they are merged on staging. That happens with the isodatetodecimaldate query in the TOML files: https://github.com/search?q=repo%3AOpenHistoricalMap%2Fohm-deploy%20isodatetodecimaldate&type=code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants