Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Notes for retrospective events hidden #21

Closed
gedankenstuecke opened this issue Mar 30, 2020 · 3 comments
Closed

UI: Notes for retrospective events hidden #21

gedankenstuecke opened this issue Mar 30, 2020 · 3 comments
Labels

Comments

@gedankenstuecke
Copy link
Member

Users can add notes to retrospective events, but this capability is rather hidden as it requires the following steps at this point: 1. create retrospective event 2. open event after creation 3. Click on "Edit event" on the event-page. 4. Write a note.

Ideally the user should be able to write a note already during the creation of the event on the /retrospective/add-event/page.

@madprime
Copy link
Member

madprime commented Mar 31, 2020

I think "notes" are already exposed in the report form? This line added them, and (I just checked) the field is present in the (admittedly ugly 😬) version on Heroku now.
https://github.com/OpenHumans/quantified-flu/blob/master/reports/forms.py#L22

I'm wrong, that's the wrong form. 🤦‍♀️

@gedankenstuecke
Copy link
Member Author

Aaaah, hadn't seen the update as I just looked after seeing the email. But maybe to make it clearer for potential contributors:

Screenshot 2020-03-31 at 18 28 01

This is the form we're talking about, at /retrospective/add-event/. It should show the notes field to be filled right away if people choose to do so :)

@madprime
Copy link
Member

Yeah, I can add this – I've got a fix for #22 too, and more stuff.

A lot of these UI things are really easy, but then I discover more issues in the process (and it seems pointless to be making issues here when I'm fixing things as I encounter them – apologies).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants