adding close link to top of about modal, for mobile users #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Whoops, i did this too (#46) as your request wasn't around at the time of considering and finally got around to it to find you have beaten me to it haha. I implemented the "x" button however so i guess it depends which one is prefered. |
|
@speizerj @nblackburn thanks! we ended up going with the X icon. the help is much appreciated though! sorry for the delay in response |
|
No worries, sounds good |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In response to #40
I think a "Close" link works better for now than an "X" icon, but certainly open to it
https://www.dropbox.com/s/a5fsjesnexaur4g/Screenshot%202015-12-19%2010.17.34.png?dl=0