Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RSA PKCS 1 optional #22

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

thalman
Copy link

@thalman thalman commented Apr 23, 2024

Many implementation of RSA PKCS 1.5 are vulnerable to marvin atack. This patch disables RSA PKCS1 by default but it allows to enable it when maintainer needs it for backward compatibility.

The issue should be fixed in underlying library, but this is not always possible hence an option to disable/enable it in cjose.

See the Marvin attack for more details about this issue.

Many implementation of RSA PKCS 1.5 are vulnerable to marvin atack.
This patch disables RSA PKCS1 by default but it allows to enable it
when maintainer needs it for backward compatibility.
@zandbelt zandbelt merged commit 721b630 into OpenIDC:version-0.6.2.x Apr 23, 2024
7 checks passed
zandbelt added a commit that referenced this pull request Apr 23, 2024
Signed-off-by: Hans Zandbelt <hans.zandbelt@openidc.com>
@tomato42
Copy link

Just for precision: while there are versions of openssl that include the mitigation known as implicit rejection, that mitigation is only active if the provider in use actually implements it. If you use some kind of HSM or PKCS#11 token, or just anything that's not the default, it's likely that the implementation is vulnerable in practice.

The changes to OpenSSL documentation about that have been merged in openssl/openssl#24159

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants