Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Object is possibly 'undefined' #141

Closed
DerekNonGeneric opened this issue Oct 16, 2022 · 0 comments
Closed

[bug] Object is possibly 'undefined' #141

DerekNonGeneric opened this issue Oct 16, 2022 · 0 comments
Labels
bug javascript PRs that update JavaScript code

Comments

@DerekNonGeneric
Copy link
Member

These issues were raised via CI run: https://github.com/openinf/util-object/actions/runs/3258038095/jobs/5349784833/

src/index.ts:138:19 - error TS2532: Object is possibly 'undefined'.

138     if (o1[k] !== o2[k]) {
                      ~~

src/index.ts:143:19 - error TS2532: Object is possibly 'undefined'.

143     if (o2[k] !== o1[k]) {
                      ~~


Found 2 errors in the same file, starting at: src/index.ts:138

This may be the (most likely) reason: a013a28#commitcomment-86935693.

@DerekNonGeneric DerekNonGeneric added bug javascript PRs that update JavaScript code labels Oct 16, 2022
DerekNonGeneric added a commit that referenced this issue Nov 3, 2022
Refs: https://babeljs.io/docs/en/assumptions#setspreadproperties

Fixes: #141
Fixes: #139

PR-URL: #138
Reviewed-by: septs <github@septs.pw>
Reviewed-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Co-authored-by: Derek Lewis <DerekNonGeneric@inf.is>
Co-authored-by: septs <github@septs.pw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug javascript PRs that update JavaScript code
Projects
None yet
Development

No branches or pull requests

1 participant