Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐ŸŽจโœจ adopting sanitize.css #851

Closed
1 task done
DerekNonGeneric opened this issue May 16, 2023 · 1 comment ยท Fixed by #1100 or #1131
Closed
1 task done

๐ŸŽจโœจ adopting sanitize.css #851

DerekNonGeneric opened this issue May 16, 2023 · 1 comment ยท Fixed by #1100 or #1131
Assignees
Labels
๐Ÿ›„ Status: Claimed Issues that have been claimed to be undertaken by someone

Comments

@DerekNonGeneric
Copy link
Member

DerekNonGeneric commented May 16, 2023

๐Ÿ› Bug report

Location

Section of the site where the content exists

Affected URL(s):

Description

Concise explanation of the problem

Our number of pages is growing, so we should start thinking about our SCSS architecture and how we intend to decompose everything modularly into separate stylesheets/templates and perhaps rethink our critical CSS strategy. We are missing a critical.css file and a reset/normalization (which we already do w/ normalize.css). A recent improvement has been made to normalize.css named sanitize.css.

Differences

normalize.css and sanitize.css correct browser bugs while carefully testing and documenting changes. normalize.css styles adhere to CSS specifications. sanitize.css styles adhere to common developer expectations and preferences. reset.css unstyles all elements. Both sanitize.css and normalize.css are maintained in sync, but only one would be necessary โ€” let's switch to sanitize.css!

Sidenote: critical extracts & inlines critical-path (above-the-fold) CSS from HTML.


  • I would like to work on this issue and submit a pull request.
@DerekNonGeneric
Copy link
Member Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ›„ Status: Claimed Issues that have been claimed to be undertaken by someone
Projects
None yet
2 participants