💄🔧：wrangle sloppy SCSS situation (integration) #1100
Conversation
👷 Deploy Preview for open-inf-is processing.
|
|
i am going out for breakfast now, but looking forward to deploy previewing this pr in a few |
There was a problem hiding this comment.
this is obviously based on bootstrap, but those source files are still missing
maybe simply get the latest version from https://getbootstrap.com & vendor it in here?
bootstrap SCSS source files have an impressive quantity of variables for facilitating theming and customization; we want those source files in here w/ those variables customized ASAP
OpenINFbot
added
the
🚅 Status: Fast Track
cloning their actual sourcecode repo would be getting us the most up-to-date look of things |
|
cloning their top-level |
DerekNonGeneric
added
the
📦 Type: Developer Dependencies
|
okay, so that top-level |
|
@DerekNonGeneric, perfect, thanks — please stop teasing us tho — knock this thing out already!! |
ok. there have been a slight change of plans tho; i am going to actually prefer bootstrap subdir: moment pls |
DerekNonGeneric
force-pushed
the
fix/sloppy-css-management
branch
from
86a889b
to
a0522a3
Compare
|
if technology choices offend anyone: the googlers already did all the work for us and we should celebrate this by capitalizing on it (my humble opinion) |
_sass/_custom.scss
Outdated
| // Breadcrumbs | ||
| // Code | ||
|
|
||
| // Colors |
There was a problem hiding this comment.
| // Colors | |
| // Colours |
okay, i am really excited about this part below as we are going to be getting our hands dirty
There was a problem hiding this comment.
we're going to be tackling 👆 in ~30min
just doing some general management tasks waiting for my coffee to kick in ❗
we seem to have 3 palettes necessary, but each of those would need color schemes for both light and dark modes, which would result in 6 distinct palettes ❗
There was a problem hiding this comment.
sorry, for delay — first time creating account there:
best thing to do now would be to first get all those colors from the file this pr is proposing to replace:
There was a problem hiding this comment.
best thing to do now would be to first get all those colors
the goal here is simply to be able to get a more clear mental picture of what we have going on and what we are missing; we are just taking inventory, but eventual color corrections are to be expected #colorTheory
not a good idea to try creating your own color there ❗(they are all taken)
we are just taking inventory
finally kicking it off here now:
- ❌ https://www.colourlovers.com/palette/4937881/OpenINFv0-IntrinSand
- ✅ https://www.colourlovers.com/palette/4937882/OpenINFv1-IntrinSand
💭 ColourLovers w/ max of 5 colours per palette must just be trolling ❗
revamping the _variables.scss for bootstrap 2024 likely give idea on qty
There was a problem hiding this comment.
we seem to have 3 palettes necessary, but each of those would need color schemes for both light and dark modes, which would result in 6 distinct palettes ❗
Originally posted by @DerekNonGeneric in #1100 (comment)
the strategy we pulled off last night was refreshing, got my creative juices flowing, and was an exercise worth repeating, so expect an increase to the 1/6th we made in progress, as you'll find on my ColourLovers profile…
see y'all 8:00pm eastern, where we bring this all together (metaphysically)
OpenINFbot
added
the
♿️ Category: Accessibility
There was a problem hiding this comment.
clarifying what all is going on here would be good
folks likely will find this to be perplexing proposal
to clarify, the Jekyll Reflection theme turning out to be somewhat of a late-developer means that all of its bootstrap-foundation styles (from ~2015) have since been outdated by the much more modern bootstrap of 2024
keeping the bootstrap foundation synchronized as bootstrap further evolves is going to be an interesting challenge, but nothing we'd shake our heads at
couple last points to get this over the finish line:
- we'd like the color scheme adapted from wherever it may currently be expressed
- please consider following the theming convention established by Jekyll proper
agreed, we would love to see the packaging of these up for others to use:
|
| background-repeat-x: repeat; | ||
| } | ||
| .outro { | ||
| background-image: url("/assets/img/jekyll-theme-reflection/prism_outro.svg"); |
There was a problem hiding this comment.
| background-image: url("/assets/img/jekyll-theme-reflection/prism_outro.svg"); | |
| background-image: url("/assets/img/svg/jekyll-theme-reflection/prism_outro.svg"); |
There was a problem hiding this comment.
🤔 shoot; tbh i am not familiar w/ proper Jekyll theming as independent structures:
please consider following the theming convention established by Jekyll proper
agreed, we would love to see the packaging of these up for others to use:
Jekyll has an extensive theme system that allows you to leverage community-maintained templates and styles to customize your site’s presentation. Jekyll themes specify plugins and package up assets, layouts, includes, and stylesheets in a way that can be overridden by your site’s content.
—https://jekyllrb.com/docs/themes/
Originally posted by @DerekNonGeneric in #1100 (comment)
thinking we gonna have to move some things around soon; time for research now too
There was a problem hiding this comment.
🤔 shoot; tbh i am not familiar w/ proper Jekyll theming as independent structures
last night i did due diligence of reading up on what we are expected to provide as theme developers and my reaction was increasing "holy moly" — excited about the whole ordeal — even made my very first RubyGems.org account — we're so back to Ruby Community
|
my mistake for not linking issue #851 sooner, but seems like working on this w/o addressing #851 would not seem to be something we'd like to see undertaken here; looking forward to making this a priority we are mindful of while at this crucial stage of development (no pun intended)… nobody probably saw this coming, but this line of work in the pr is starting to force us to figure out what we're all about — something we've generally been happy to leave as undefined/open-ended, but maybe take a look at the facilities we have currently in planning (visible via full-fledged SCSS files), you'll notice that what we gave ourselves is:
|
i mean, that is not to say that this org has no identity or is cultureless, but we have been thru what can only be described as perhaps various community lifecycles (?) w/ some of the most influential people in open-source who've come to us to collaborate and leave their mark |
DerekNonGeneric
force-pushed
the
fix/sloppy-css-management
branch
from
7d7f408
to
f903b42
Compare
|
we need to keep driving in the same direction as last night: ~30min until shuttle takeoff some relevant hive-mind things happened last night (and earlier this week),
first thing's first: the initial color scheme of the main star of the show:
wow, same energy as the funnies (?)
|
DerekNonGeneric
force-pushed
the
fix/sloppy-css-management
branch
from
5febef3
to
33e32c2
Compare
unprocessed assets should be optimized further via tooling
OpenINFbot
force-pushed
the
fix/sloppy-css-management
branch
from
33e32c2
to
a703e39
Compare
DerekNonGeneric
added
📖 Category: Documentation
.vscode/settings.json
Outdated
| @@ -21,7 +21,7 @@ | |||
| // Auto-fix JS files with ESLint using our custom settings. Needs | |||
There was a problem hiding this comment.
this change no longer necessary
| {% endcapture %} | ||
| {{ styles | scssify }} | ||
| {% endif %} | ||
| {% if page.class == 'collections' %} |
There was a problem hiding this comment.
| {% if page.class == 'collections' %} | |
| {% if page.class == 'collections' %} |
| $primary: $blue !default; | ||
| $secondary: $gray-600 !default; | ||
| $success: $green !default; | ||
| $info: $cyan !default; | ||
| $warning: $yellow !default; | ||
| $danger: $red !default; | ||
| $light: $gray-100 !default; | ||
| $dark: $gray-900 !default; |
There was a problem hiding this comment.
total for theme palette's color qty seems like 8 here, but those other colors above maybe should be customized by theme authors as well
DerekNonGeneric
added
🛄 Status: Claimed
OK, it's a lot to go over now haha; and almost time for bed maybe tomorrow we can pick it back up |
DerekNonGeneric
force-pushed
the
live
branch
5 times, most recently
from
f1a3fd0
to
62bd1ad
Compare
❌ Deploy Preview for openinfis failed.
|
This reverts commit 33d717a.
this pr is expected to be tackling both
aforementioned problems from linked issues below:
Refs: #851
Refs: #1098 (comment)