This repository has been archived by the owner on Apr 11, 2024. It is now read-only.
🏗✨：add check engines task: validate devenv/automate prereqs check #1023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DerekNonGeneric
added
enhancement
🟨 Code: JS/TS
|
opened as draft since this still needs to be wired up (should run asap when project bootstraps) |
DerekNonGeneric
force-pushed
the
fix/check-engines
branch
from
bee37f2
to
0e961f2
Compare
DerekNonGeneric
commented
Nov 11, 2023
DerekNonGeneric
commented
Nov 11, 2023
DerekNonGeneric
commented
Nov 11, 2023
_tasks/check-package-engines.js
Outdated
Comment on lines
16
to
17
| * @license MIT | ||
| * @module {CjsModule} tasks/check-package-engines |
There was a problem hiding this comment.
Suggested change
| * @license MIT | |
| * @module {CjsModule} tasks/check-package-engines | |
| * @license MIT | |
| * @module {CJSModule} build/tasks/check-package-engines |
There was a problem hiding this comment.
this is a verification task, so i think it would better go in verify dir
build/tasks/verify/verify-engines
DerekNonGeneric
commented
Nov 11, 2023
DerekNonGeneric
commented
Nov 13, 2023
DerekNonGeneric
commented
Nov 13, 2023
DerekNonGeneric
commented
Nov 13, 2023
DerekNonGeneric
commented
Nov 13, 2023
DerekNonGeneric
commented
Nov 13, 2023
DerekNonGeneric
commented
Nov 13, 2023
This comment was marked as resolved.
This comment was marked as resolved.
DerekNonGeneric
force-pushed
the
fix/check-engines
branch
from
5ac7f42
to
d4c2e5b
Compare
|
This is not the solution we will be going with, but simply something i had in mind earlier and this is riddled w. erroneous code, but feel free to revive this if someone thinks it should. ^^ |
DerekNonGeneric
commented
Jan 25, 2024
There was a problem hiding this comment.
okay, we are going to try again 🥺
/cc @jorgebucaran as likely has a good solution already?
DerekNonGeneric
force-pushed
the
fix/check-engines
branch
from
d4c2e5b
to
74685ae
Compare
OpenINFbot
added
the
🛠️ Category: Tools
|
possibly relevant to the remarks above regarding appropriate directory structure: |
There is only one real way to do this properly and it must be done out-of-band (not tool-side) since running a wrong version of the tool (e.g., pnpm) could be catastrophic in some extreme cases (version/api slippage, other mismatches). Fixes: #1017
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: Derek Lewis <DerekNonGeneric@inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
…-package-engines.mjs Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
…y-manifests.mjs Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
OpenINFbot
force-pushed
the
fix/check-engines
branch
from
5f6bcfd
to
f9ec665
Compare
Co-authored-by: Derek Lewis <dereknongeneric@open.inf.is> Signed-off-by: OpenINF-bot <openinfbot@open.inf.is>
OpenINFbot
approved these changes
Apr 5, 2024
DerekNonGeneric
added a commit
to OpenINF/open.inf.is
that referenced
this pull request
Apr 8, 2024
…rereqs check OpenINF#1023"" This reverts commit c99a891.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is only one real way to do this properly and it must be done out-of-band (not tool-side) since running a wrong version of the tool (e.g., pnpm) could be catastrophic in some extreme cases (version/api slippage, other mismatches).
Fixes: #1017
/cc @OpenINF/wg-a-team