🏗♻️：rm js console expressions as prep for logging framework adoption #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![deepsource-autofix[bot]](https://avatars.githubusercontent.com/in/57168?s=60&v=4){kind=small}
It is considered a best practice to avoid the use of any `console` methods in JavaScript code that will run on the browser. **NOTE:** If your repository contains a server side project, you can add `"nodejs"` to the `environment` property of analyzer meta in `.deepsource.toml`. This will prevent this issue from getting raised. Documentation for the analyzer meta can be found [here](https://docs.deepsource.com/docs/analyzers-javascript#meta). Alternatively, you can silence this issue for your repository [as shown here](https://deepsource.com/blog/releases-issue-actions). If a specific `console` call is meant to stay for other reasons, you can add [a skipcq comment](https://docs.deepsource.com/docs/issues-ignore-rules#silencing-a-specific-issue) to that line. This will inform other developers about the reason behind the log's presence, and prevent DeepSource from flagging it.
👷 Deploy Preview for open-inf-is processing.
|
DerekNonGeneric
requested changes
Feb 28, 2024
OpenINFbot
added
the
⛔ Status: Blocked
DerekNonGeneric
force-pushed
the
live
branch
4 times, most recently
from
c5427e7
to
8c69b01
Compare
DerekNonGeneric
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
even as ex-@nodejs core, my position on this PR is still -1 BUT
and a big BUT: a logging framework should preferably be used
merging in good faith effort & also propose our switching @pinojs
See: https://getpino.io
DerekNonGeneric
added
the
🟨 Code: JS/TS
DerekNonGeneric
changed the title
OpenINFbot
approved these changes
Mar 29, 2024
✅ Deploy Preview for openinfis ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
DerekNonGeneric
added
the
🗳️ Status: Author Ready
✅ Deploy Preview for openinfis ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is>
See OpenINF/nps — fork of project repo @ OpenINF-private/openinf-nps (with no known issues to date). |
|
this dang merge conflict is w/e — we can let this one rot here, but we can address insufficiencies we have found w/ off-the-shelf nps using @pinojs is necessary |
DerekNonGeneric
added a commit
that referenced
this pull request
Mar 29, 2024
PR URL: #1157 Reviewed-by: Derek Lewis <dereknongeneric@open.inf.is> Reviewed-by: OpenINF-bot <openinfbot@open.inf.is> Signed-off-by: Derek Lewis <dereknongeneric@open.inf.is> Cc: Grimes <grimes@open.inf.is> Refs: https://github.com/OpenINF/nps Co-Authored-By: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com> Co-Authored-By: Derek Lewis <dereknongeneric@open.inf.is>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is considered a best practice to avoid the use of any
consolemethods in JavaScript code that will run on the browser.NOTE: If your repository contains a server side project, you can add
"nodejs"to theenvironmentproperty of analyzer meta in.deepsource.toml.This will prevent this issue from getting raised.
Documentation for the analyzer meta can be found here.
Alternatively, you can silence this issue for your repository as shown here.
If a specific
consolecall is meant to stay for other reasons, you can add a skipcq comment to that line.This will inform other developers about the reason behind the log's presence, and prevent DeepSource from flagging it.