Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🏗✨:include new markdown linter #1206

Merged
merged 20 commits into from
Mar 21, 2024

Conversation

DerekNonGeneric
Copy link
Member

WIP of incorporating new markdown linter into our workflows

@DerekNonGeneric DerekNonGeneric self-assigned this Mar 21, 2024
Copy link

netlify bot commented Mar 21, 2024

👷 Deploy Preview for open-inf-is processing.

Name Link
🔨 Latest commit 21daa41
🔍 Latest deploy log https://app.netlify.com/sites/open-inf-is/deploys/65fbe3c77cb9b3000809d1e5

@DerekNonGeneric DerekNonGeneric added 📦 Type: Developer Dependencies PRs that modify packages only req'd for local development and testing 🚅 Status: Fast Track PRs that do not need to wait for 48 hours to land 🏗️ Category: Infrastructure/Tooling/Builds/CI undefined 🌖 P1: High undefined 🚧 Status: Work In Progress (WIP) undefined ✨ Type: Feature undefined labels Mar 21, 2024
@DerekNonGeneric
Copy link
Member Author

this pr is prereq to #1123 and others;
see #1123 (comment)

@DerekNonGeneric
Copy link
Member Author

i took this from https://github.com/OpenINF/.github/blob/main/build/tasks/verify/verify-md.mjs, but am noticing it has problems now…

@DerekNonGeneric
Copy link
Member Author

ok, we are just going to go w/ the flow on this a quickly merge so we can get back to work

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Mar 21, 2024

@DerekNonGeneric
Copy link
Member Author

DerekNonGeneric commented Mar 21, 2024

@DerekNonGeneric
Copy link
Member Author

dang, linguist is still being annoying and not properly detecting documentation (even following documented way of overriding in .gitattributes)

@DerekNonGeneric DerekNonGeneric added the 🗳️ Status: Author Ready PRs that are considered ready by their author label Mar 21, 2024
@DerekNonGeneric
Copy link
Member Author

oh wow, looks like we have a little more to go:

🔗 https://github.com/DavidAnson/markdownlint-cli2?tab=readme-ov-file#compatibility

Copy link

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@iktakahiro/markdown-it-katex@4.0.1 Transitive: filesystem, shell +2 3.94 MB iktakahiro
npm/markdown-it-abbr@2.0.0 None 0 21.2 kB vitaly
npm/markdown-it-anchor@8.6.7 None +3 202 kB valeriangalliat
npm/markdown-it-footnote@4.0.0 None 0 46.8 kB vitaly
npm/markdown-it-sub@2.0.0 None 0 9.57 kB vitaly
npm/markdown-it-sup@2.0.0 None 0 9.61 kB vitaly
npm/markdown-it-task-lists@2.1.1 None 0 23.1 kB revin
npm/markdown-it-toc-done-right@4.2.0 None 0 73.8 kB nagaozen
npm/markdown-it@14.1.0 Transitive: environment, filesystem +6 1.49 MB vitaly
npm/markdownlint-cli2-formatter-default@0.0.4 None 0 5.19 kB davidanson
npm/markdownlint-cli2@0.12.1 Transitive: environment, filesystem +34 3.56 MB davidanson

🚮 Removed packages: npm/vnu-jar@23.4.11

View full report↗︎

@OpenINFbot OpenINFbot merged commit 61f27b8 into OpenINF:live Mar 21, 2024
18 checks passed
@DerekNonGeneric
Copy link
Member Author

well, we will have to do a follow-up (tomorrow);
seems the exit code doesn't fail ci;
see https://github.com/OpenINF/openinf.github.io/actions/runs/8371423211/job/22920438981?pr=1184

also, would like everything wrong w/ those documents to be corrected

@DerekNonGeneric DerekNonGeneric deleted the feat/markdown-lint-cli2 branch March 21, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏗️ Category: Infrastructure/Tooling/Builds/CI undefined 🌖 P1: High undefined 🗳️ Status: Author Ready PRs that are considered ready by their author 🚅 Status: Fast Track PRs that do not need to wait for 48 hours to land 🚧 Status: Work In Progress (WIP) undefined 📦 Type: Developer Dependencies PRs that modify packages only req'd for local development and testing ✨ Type: Feature undefined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants