Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wind models #216

Merged
merged 18 commits into from Oct 13, 2020
Merged

Fix wind models #216

merged 18 commits into from Oct 13, 2020

Conversation

dietmarw
Copy link
Member

Fixes based on master branch of @marcelofcastro

@marcelofcastro @dietmarw
Fixing units for submodels
ea468dc
@marcelofcastro @dietmarw
Fixing units for wt3g1
f85d442
@marcelofcastro @dietmarw
Fixing units for wt3e1
a2893a4
@marcelofcastro @dietmarw
Fixing units for wt4g1
74fc677
@marcelofcastro @dietmarw
fixing units for wt4e1
53d3be4
@marcelofcastro @dietmarw
Fixing statement for initial angle in radians
58c5fc7
@marcelofcastro @dietmarw
Adding missing first order block
6c49603
@marcelofcastro @dietmarw
Implementing correct integrator with variable limits
863b5ab
@marcelofcastro @dietmarw
Fixing CCL Q and P priority outputs
758b944
@marcelofcastro @dietmarw
Fixing Wind Control Emulator, using correct CCL and IntegratorLimVar
02912ca
@marcelofcastro @dietmarw
Cleaning and fixing WT4G and WT4E examples
f129f58
@marcelofcastro @dietmarw
Including WT4E1 as example
f1954b0
@marcelofcastro @dietmarw
removing old wt4g_wt4e example
e2f39fa
@marcelofcastro @dietmarw
Adding stop time for example
a516506
@marcelofcastro @dietmarw
Reimplementing ramp-tracking filter as PSSE's undocumented implementa…
457f244 
…tion
@marcelofcastro @dietmarw
Fixing filter for when M = 0
07fc059
@marcelofcastro @dietmarw
Fixing mistake that allowed active power to initialize at wrong value
be45aeb
@marcelofcastro @dietmarw
Fixing typos in variable description
ebf0dfe
@dietmarw dietmarw self-assigned this Oct 13, 2020
@dietmarw dietmarw added the bug label Oct 13, 2020
marcelofcastro
marcelofcastro approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@marcelofcastro marcelofcastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files were reviewed and merge is approved.

@dietmarw dietmarw added this to the 2.0.0 milestone Oct 13, 2020
@dietmarw dietmarw merged commit 1e2e64a into OpenIPSL:master Oct 13, 2020
@dietmarw dietmarw deleted the fixWind branch October 13, 2020 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelofcastro marcelofcastro marcelofcastro approved these changes

Assignees

@dietmarw dietmarw

Labels
bug hacktoberfest-accepted
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dietmarw @marcelofcastro