Updates to the PV all-in-one model #345
Conversation
The following are a list of updates: 1) The AddOnBlock (Irradiance to Power) was missing machine base power to transform the output power from MW to p.u. 2) The user now has the option of using the addOn block with the PV model through a boolean parameter. Toggling the parameter enables or disables a realinput that allows the connection to the addOn. This works with all control modes in the PV model. 3) Created a new Test model called PVPlantSolarIrradiance, that is documented.
|
Wow this is rather confusing that you have created a fork for the purpose of the PR. It took me quite some time to find the commit in the log. For the future you should have a fork of OpenIPSL under your user, i.e., fachif/OpenIPSL and there you create branches on which you can develop your features (hence the name, feature-branches). Those branches can then be used to create PRs against OpenIPSL:master. Renaming your forks to something else then the project it is forked from will cause massive confusions. I see you've done the same with Microgrids. |
| @@ -3,6 +3,7 @@ package AddOnBlocks | |||
| "This package contains additional add ons that can be added to the original renewable models." | |||
| model IrradianceToPower "PV Array Power Output from Irradiance." | |||
|
|
|||
| parameter Modelica.Units.SI.ApparentPower M_b = 100000000; | |||
There was a problem hiding this comment.
You are missing the description string. What is this parameter supposed to represent.
| annotation (Icon(coordinateSystem(preserveAspectRatio=false, extent={{-100, | ||
| -100},{120,100}})), Diagram( | ||
| coordinateSystem(preserveAspectRatio=false, extent={{-100,-100},{100, | ||
| 100}}))); |
There was a problem hiding this comment.
| annotation (Icon(coordinateSystem(preserveAspectRatio=false, extent={{-100, | |
| -100},{120,100}})), Diagram( | |
| coordinateSystem(preserveAspectRatio=false, extent={{-100,-100},{100, | |
| 100}}))); |
no need for these also the icon aspect ration is non-standard and would just disturb the appearance.
| __Dymola_NumberOfIntervals=5000, | ||
| __Dymola_Algorithm="Dassl"), Documentation(info="<html> |
There was a problem hiding this comment.
Do not use vendor annotations. Use interval instead and stop the algorithm since that is the default anyway.
The following are a list of updates: