Fix warnings on some 32 bit platforms #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason, certain 32 bit platforms have gcc errors about this spot leading to uninitialized variables (they don't! but gcc can't seem to figure that out). The 64 bit platforms figure it out just fine, so just eat the cost of a couple useless assigns on the platforms where it's a problem.
|
Applies cleanly to 1.7.7 and seems to work! LGTM. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Oct 19, 2016
For some reason, certain 32 bit platforms have gcc errors about this spot leading to uninitialized variables (they don't! but gcc can't seem to figure that out). The 64 bit platforms figure it out just fine, so just eat the cost of a couple useless assigns on the platforms where it's a problem.
|
Merged into both master and RB-1.7. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, certain 32 bit platforms have gcc errors about this spot leading to uninitialized variables (they don't! but gcc can't seem to figure that out). The 64 bit platforms figure it out just fine, so just eat the cost of a couple useless assigns on the platforms where it's a problem.