Stop using typedefs ImageIOParameter & ImageIOParameterList #1690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just use ParamValue and ParamValueList. Those typedefs never served any purpose, just deprecate them.
|
LGTM Maybe add the deprecated attribute (for gcc/clang at least?) to flag any external code that might be using them? |
|
Since many people by default compile in the mode where deprecation attributes break their build, I usually phase in the deprecation over time. Doing it right in master in the same checkin where I made the change, without any real warning, seems too quick. Usually around the time that master branches for the next release (and becomes a beta), I add the deprecation attributes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just use ParamValue and ParamValueList. Those typedefs never served any purpose, just deprecate them.