Fix FindOpenEXR.cmake to use version detected by pkg-config, if available #2057
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able Detecting the OpenEXR version by parsing a C header can be unreliable. Since we already use pkg-config to detect the presence of the library, we can also use the version number it gives us, if available, and only resort to parsing the header file if that failed. See-Also: https://bugs.gentoo.org/668412 Fixes: ec4f679
devurandom
changed the title
|
Looking good this time! |
lgritz
pushed a commit
to lgritz/OpenImageIO
that referenced
this pull request
Nov 10, 2018
…able (AcademySoftwareFoundation#2057) Detecting the OpenEXR version by parsing a C header can be unreliable. Since we already use pkg-config to detect the presence of the library, we can also use the version number it gives us, if available, and only resort to parsing the header file if that failed. See-Also: https://bugs.gentoo.org/668412 Fixes: ec4f679
|
Backported to 1.8. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detecting the OpenEXR version by parsing a C header can be unreliable. Since
we already use pkg-config to detect the presence of the library, we can also
use the version number it gives us, if available, and only resort to parsing
the header file if that failed.
See-Also: https://bugs.gentoo.org/668412
Fixes: ec4f679
Description
See commit message. I suggest to backport this to branch RB-1.8.
Tests
I applied this patch to release 1.8.16 and successfully compiled a Gentoo package with it.
Checklist:
have previously submitted a Contributor License Agreement
(individual, and if there is any way my
employers might think my programming belongs to them, then also
corporate).
(adding new test cases if necessary).