Python: Direct support for 'half' using numpy.float16 type #2694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When transferring blocks of pixels (for example, by ImageInput.read_image or ImageOutput.write_image), "half" pixels ended up mangled into uint16, the only type of the right bit width. But NumPy has a numpy.float16 type! A little bit of extra hinting to pybind11 makes this work as users probably expect. Signed-off-by: Larry Gritz <lg@larrygritz.com>
|
Reported on #2689 that this solves the problem. Merging. |
lgritz
added a commit
to lgritz/OpenImageIO
that referenced
this pull request
Sep 3, 2020
…ftwareFoundation#2694) When transferring blocks of pixels (for example, by ImageInput.read_image or ImageOutput.write_image), "half" pixels ended up mangled into uint16, the only type of the right bit width. But NumPy has a numpy.float16 type! A little bit of extra hinting to pybind11 makes this work as users probably expect. Fixes AcademySoftwareFoundation#2689 Signed-off-by: Larry Gritz <lg@larrygritz.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When transferring blocks of pixels (for example, by ImageInput.read_image
or ImageOutput.write_image), "half" pixels ended up mangled into uint16,
the only type of the right bit width.
But NumPy has a numpy.float16 type! A little bit of extra hinting to
pybind11 makes this work as users probably expect.
Fixes #2689
Signed-off-by: Larry Gritz lg@larrygritz.com