Application bug fixes and performance enhancements #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This dragged in all the commits from #35, because it has not been merged yet. |
|
Yes, thanks @dzenanz, if this becomes good enough to consider truly adding, I'll either tack it on to the end of that PR, or else rebase this on master (after that's merged). |
|
Time to rebase :D |
scottwittenburg
force-pushed
the
perf-itkjs-workerpool
branch
from
2bcfee2
to
82dc812
Compare
scottwittenburg
force-pushed
the
perf-itkjs-workerpool
branch
from
82dc812
to
35e26ca
Compare
|
This will need the cancel api addition to the |
Previously scans were marked as loaded or not loaded using filled vs. empty disc next to each scan. The computation for this was done efficiently, but was ultimately incorrect as the scan was marked as loaded as soon as a worker had picked up the last image to load. In cases where the only image in a scan is really large, the scan could be marked as loaded before it was actually ready. This change removes the filled circles indicating individual scans are loaded or not in favor of a single icon located next to the experiment name.
scottwittenburg
force-pushed
the
perf-itkjs-workerpool
branch
from
752cef5
to
fecbbdc
Compare
scottwittenburg
changed the title
scottwittenburg
commented
Feb 24, 2021
client/src/components/JSONConfig.vue
Outdated
| v => | ||
| v.endsWith('.json') || | ||
| v.endsWith('.csv') || | ||
| 'Needs to be a json file' |
There was a problem hiding this comment.
I thought I had replaced this with "Needs to be a json or csv file", but I must have missed it. I'll fix it before we merge.
dzenanz
approved these changes
Feb 24, 2021
thewtex
approved these changes
Feb 25, 2021
|
itk-js + miqa = big smile :) |
* Omit the "reviewer" text field * Enable the "Bad" button as soon as a character is entered in the note * Move the percent-loaded indicator in between double chevrons * Overwrite any existing notes/ratings upon importing a CSV
jimklo
suggested changes
Mar 11, 2021
devops/docker/Dockerfile
Outdated
| @@ -9,7 +9,7 @@ RUN apt-get update && apt-get install -qy \ | |||
| libsasl2-dev && \ | |||
| apt-get clean && rm -rf /var/lib/apt/lists/* | |||
|
|
|||
| RUN wget https://bootstrap.pypa.io/get-pip.py && python3 get-pip.py | |||
| RUN wget https://bootstrap.pypa.io/3.5/get-pip.py && python3 get-pip.py | |||
There was a problem hiding this comment.
This URL causes an error on build.
Should be https://bootstrap.pypa.io/pip/3.5/get-pip.py instead.
|
@jeffbaumes This is the PR I was just mentioning |
Only reviewer and above (reviewer, manager, admin) shouild be able to see the widgets that allow editing, like the rating buttons and note edit field. Also, make the 'Bad' button visible to anyone who can see the rest of the edit widgets.
Every time we run "docker-compose up", the provisioning script clobbers some of the email server settings which were previously configured correctly. This change puts those values into the .env.template file, so the user can set them in their .env file, and then provisions with those values instead, so once the correct values are set, they can be preserved across restarts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several issues with the application:
Closes #18. Closes #42.