Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple HTML not converted from SMF 2.0.x #103

Closed
Frenzie opened this issue Apr 14, 2016 · 2 comments · Fixed by #107
Closed

Simple HTML not converted from SMF 2.0.x #103

Frenzie opened this issue Apr 14, 2016 · 2 comments · Fixed by #107
Labels
Milestone

Comments

@Frenzie
Copy link

Frenzie commented Apr 14, 2016

In SMF, simple HTML was stored like:

<img src="whatever">

In Elk, that has become:

<img src="whatever">

This should preferably be converted during the import process.

@emanuele45
Copy link
Contributor

I guess some overzealousness in htmlspecialchar'ring the body of the messages. 👼

@emanuele45 emanuele45 added the bug label Apr 14, 2016
@emanuele45 emanuele45 added this to the 1.0 milestone Apr 14, 2016
@Vekseid
Copy link
Contributor

Vekseid commented Sep 3, 2019

This is the wrong way around from what is occurring.

The converter changes

<img src="whatever">

into

<img src="whatever">

And Elkarte doesn't understand the result.

However, at least as of 1.1 " still gets converted into & quot; for the database, and ' to &# 039;. It's still generating

<br />

On newlines.

The fixTexts method in the SMF common source is accordingly unnecessary and should be removed. It should only be a thing if/when Elkarte's handling of these things actually changes.

Even then, this should not be done on a row-by-row basis, but rather with a query that alters the database en masse, which is very quick and runs in seconds even for multi-million row conversions.

Vekseid added a commit to Vekseid/openimporter that referenced this issue Sep 3, 2019
@Vekseid Vekseid mentioned this issue Sep 3, 2019
@Spuds Spuds closed this as completed in #107 Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants