Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add epub generation #94

Closed
wants to merge 2 commits into from
Closed

Conversation

mebenn
Copy link
Contributor

@mebenn mebenn commented Dec 28, 2017

makepdf.sh now updated to produce epub output for mobile devices.

Added a new option -t epub (or -t pdf which is default). Script should be renamed as it was originally only intended to produce pdf!

The quality of the output is not great, it needs tweaking to produce high quality epub output.

For help, try
makepdf.sh -h

@pyhalov pyhalov requested a review from xen0l October 23, 2018 04:34
@xen0l
Copy link
Contributor

xen0l commented Nov 2, 2018

@pyhalov I reviewed and this sort of works. There are some problems e.g. epub was lacking pictures, but I didn't investigate.

RBAC example is incorrect

Fix error reporting pandoc not installed

Although pandoc was installed, a typo caused this error always to
appear.

Add support for producing epub

New option added -t <pdf || epub>
To produce epub output use  -t epub.
Pdf is default.

Fix reviewer suggestion, but improve

Fix reviewer suggestion

Fix error reporting pandoc not installed

Although pandoc was installed, a typo caused this error always to
appear.

Add support for producing epub

New option added -t <pdf || epub>
To produce epub output use  -t epub.
Pdf is default.
@mebenn
Copy link
Contributor Author

mebenn commented Jun 4, 2021

This PR was been superceded by more recent changes in makepdf.sh, so I'll close the PR soon whenm I have time or unless someone has any objections

@JMadgwick
Copy link
Contributor

These changes have been now merged as #187

@JMadgwick JMadgwick closed this Jun 8, 2021
@mebenn mebenn deleted the add_epub_generation branch March 24, 2023 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants