image/library/libtiff: build with libjpeg8-turbo

[timmooney]

Rebuild image/library/libtiff with libjpeg8-turbo.

Besides the standard stuff (updating REQUIRED_PACKAGES, bumping COMPONENT_REVISION, adding the necessary CFLAGS/CPPFLAGS/CXXFLAGS/LDFLAGS), I updated the COMPONENT_PROJECT_URL. The old one results in a 404.

Also, the component doesn't specify any test suite, but libtiff does have a "check" target that passes for both i86 and amd64 when I run them manually from the respective build directory. I tried switching the test target to 'test: $(TEST_32_and_64)' but then all the tests fail with a libtool error, so I left the test target as it is.

Finally, after the rebuild:

/usr/bin/amd64/fax2ps
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/fax2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/pal2rgb
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/ppm2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/raw2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiff2bw
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiff2pdf
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiff2ps
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiff2rgba
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffcmp
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffcp
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffcrop
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffdither
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffdump
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffinfo
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffmedian
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffset
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/amd64/tiffsplit
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/bin/fax2ps
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/fax2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/pal2rgb
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/ppm2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/raw2tiff
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiff2bw
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiff2pdf
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiff2ps
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiff2rgba
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffcmp
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffcp
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffcrop
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffdither
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffdump
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffinfo
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffmedian
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffset
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/bin/tiffsplit
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/lib/amd64/libtiff.so
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/lib/amd64/libtiff.so.5
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/lib/amd64/libtiff.so.5.2.5
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/amd64/libjpeg.so.8
/usr/lib/libtiff.so
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/lib/libtiff.so.5
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8
/usr/lib/libtiff.so.5.2.5
        libjpeg.so.8 =>  /usr/lib/libjpeg8-turbo/lib/libjpeg.so.8

[alarcher]

@timmooney Could you try adding ENV+= -i and check the test suite again?

[alarcher]

Modulo the tests, OK.

[alarcher]

If the trick with ENV works then add the tests.

[pyhalov]

also 'unexport SHELLOPTS' can be more polite way to fix this issue

[pyhalov]

Any update on it?

[timmooney]

Sorry, this week is busy with projects, it will probably be Friday before I can try what you've suggested

[xen0l]

@timmooney any update?

[timmooney]

Sorry for the delay, I continue to be busy with projects.

I tried what Alexander suggested with ENV += -i and that fixed the issue -- all 78 tests in the testsuite now pass for both 32 and 64 bit builds.

Should I update my pull request with that change, or does @pyhalov prefer that I use 'unexport SHELLOPTS'? After his hint about that, I see the comments in a few other Makefiles.

[pyhalov]

unexport SHELLOPTS seems to be less rude, but in this case it doesn't matter much

[timmooney]

I've amended the pull request to also include 'unexport SHELLOPTS' and enabled the test suite. I tested with the unexport and all tests pass with that.

@alarcher and @pyhalov please review.