Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump valgrind to 3.13.0 #3295

Merged
merged 1 commit into from Jun 23, 2017
Merged

Conversation

alarcher
Copy link
Contributor

No description provided.

@alarcher
Copy link
Contributor Author

Should be safe to merge.

@pyhalov
Copy link
Contributor

pyhalov commented Jun 22, 2017

Got build failure on gmake test:

/export/home/alp/srcs/tests/oi-userland/components/developer/valgrind/valgrind-3.13.0/memcheck/tests/x86-solaris/scalar.c:3:20: fatal error: scalar.h: No such file or directory
 #include "scalar.h"
                    ^
compilation terminated.

@pyhalov
Copy link
Contributor

pyhalov commented Jun 22, 2017

test results differ:

openexr/build/test/i86/results-32.snapshot       2017-06-23 01:08:17.457381517 +0000
@@ -17227,6 +17227,15 @@
          3x8
          2x8
          1x8
+      Inverse, AVX: 
+         8x8
+         7x8
+         6x8
+         5x8
+         4x8
+         3x8
+         2x8
+         1x8
 ok

@alarcher
Copy link
Contributor Author

@pyhalov my machine does not have AVX

@pyhalov
Copy link
Contributor

pyhalov commented Jun 23, 2017

How can we make tests reproducible? Remove architecture-dependent results? Avoid shipping results relying on tests just pass?

@alarcher
Copy link
Contributor Author

@pyhalov Do we talk about valgrind here or openexr? It seems you posted on the wrong PR. If it is openexr, I'll look at disabling AVX.

@pyhalov
Copy link
Contributor

pyhalov commented Jun 23, 2017

Yes, wrong PR

@alarcher
Copy link
Contributor Author

@pyhalov Do you need something more on this PR?

@pyhalov pyhalov merged commit 5509ef7 into OpenIndiana:oi/hipster Jun 23, 2017
@alarcher alarcher deleted the valgrind313 branch December 7, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants