Virtualbox 5.2.22 #4569

alarcher · 2018-10-30T19:04:43Z

Need to write install and patch USB possibly.

timmooney · 2018-10-30T22:28:10Z

Just tried a build using the commit from @pyhalov and @alarcher 's pull with the 5.2.20 diffs, and I get a build failure on my build system because of missing sys/soundcard.h:

/export/home/mooney/oi-userland/components/sysutils/virtualbox/build/amd64/src/VBox/Devices/Audio/DrvHostOSSAudio.cpp:22:27: fatal error: sys/soundcard.h: No such file or directory
 #include <sys/soundcard.h>
                           ^
compilation terminated.
kmk: *** [/export/home/mooney/oi-userland/components/sysutils/virtualbox/build/amd64/out/solaris.amd64/release/obj/VBoxDD/Audio/DrvHostOSSAudio.o] Error 1

I see that --enable-pulse is specified as one of the configure options. Should that preclude the OSS stuff being built? I'm just trying to understand whether the intent is that pkg:/system/header/header-audio should be required to build or not.

alarcher · 2018-10-30T22:40:32Z

@timmooney Since I have not been all the way to the REQUIRED_PACKAGES stage, build dependencies are not specified yet. You are correct that headers should be installed.

alarcher · 2018-11-13T19:33:02Z

Works but some issue with the interface, only runs as root...

pyhalov · 2018-11-13T21:19:40Z

components/sysutils/virtualbox/files/Makefile

@@ -1,34 +1,161 @@
-BINDIR = out/solaris.amd64/release/bin
-DRVS = vboxnet vboxdrv vboxflt vboxusb vboxusbmon
+PREFIX = /opt/VirtualBox


is this file used?

I do not think so but I left it since you added it, just in case.
Should be cleaned up just before merge.

pyhalov · 2018-11-13T21:27:24Z

components/sysutils/virtualbox/virtualbox.p5m

@@ -22,6 +22,111 @@ set name=org.opensolaris.consolidation value=$(CONSOLIDATION)

 license $(COMPONENT_LICENSE_FILE) license='$(COMPONENT_LICENSE)'

+set name=variant.opensolaris.zone value="global"


Can we mark only drivers with it (if necessary)? I suppose, one can run VirtualBox in zone, if corresponding drivers are passed to zone.

pyhalov · 2018-11-13T21:28:26Z

components/sysutils/virtualbox/virtualbox.p5m

@@ -22,6 +22,111 @@ set name=org.opensolaris.consolidation value=$(CONSOLIDATION)

 license $(COMPONENT_LICENSE_FILE) license='$(COMPONENT_LICENSE)'

+set name=variant.opensolaris.zone value="global"
+set name=pkg.depend.runpath value=$PKGDEPEND_RUNPATH:opt/VirtualBox/amd64


s/amd64/$(MACH64)/

pyhalov · 2018-11-13T21:30:02Z

components/sysutils/virtualbox/virtualbox.p5m

+file path=usr/share/mime/packages/virtualbox.xml
+file path=usr/share/pixmaps/VBox.png
+file path=usr/share/pixmaps/virtualbox.png
+file path=var/svc/manifest/application/virtualbox/virtualbox-autostart.xml


Should we place it in /lib/svc/manifest ?

pyhalov · 2018-11-13T21:30:46Z

components/sysutils/virtualbox/virtualbox.p5m

+#file path=vbox.pkginfo
+#file path=vbox.space
+
+driver name=vboxdrv 


Do we want to have separate driver package or mark drivers as GZ-only content?

Problem is that the script for post/pre-install steps assumes that all files are delivered. Would need some time to look at splitting the logic if a different package are provided for drivers.
Should I use a transform to mark drivers are GZ-only content? I have never done this.

Just add variant.opensolaris.zone=global to driver action

It does not work, it chokes on the actual driver files and if the same is added to them pkg returns an internal error.

Sorry, looking at illumos-gate build receipts, it seems variant.opensolaris.zone=global should be added only to actual files.

pyhalov · 2018-11-13T21:32:52Z

components/sysutils/virtualbox/Makefile

 CONFIGURE_OPTIONS+= --disable-python
 CONFIGURE_OPTIONS+= --disable-sdl-ttf
 CONFIGURE_OPTIONS+= --disable-libvpx
 CONFIGURE_OPTIONS+= --nofatal

+VBOX_PREFIX   = /opt/VirtualBox


Do we want to stick to /opt/VirtualBox layout or move it to /usr/virtualbox or /usr/lib/virtualbox to be more consistent with other packages?

If we want another prefix we need to patch configuration and install scripts.
That would be better probably but I will not have time to look at this in the coming two weeks.

alarcher · 2018-11-15T08:04:10Z

@pyhalov Given that I will be busy with relocation, feel free to push whichever change you want to the PR and merge it if you like. I cannot guarantee that I'll have time to review this in the coming two weeks.

pyhalov · 2018-12-05T05:59:34Z

kmk: *** No rule to make target `/libQt5Core.so', needed by `/export/home/alp/srcs/oi-userland/components/sysutils/virtualbox/build/amd64/out/solaris.amd64/release/obj/VBoxDbg/VBoxDbg.so'.  Stop.
kmk: *** Waiting for unfinished jobs....

components/sysutils/virtualbox/Makefile

pyhalov · 2018-12-05T07:06:30Z

I can install virtualbox in zone, but I haven't tried to actually run it there...

pyhalov · 2018-12-05T08:31:25Z

components/sysutils/virtualbox/Makefile

+
+COMPONENT_NAME=         VirtualBox
+COMPONENT_VERSION=      5.2.22
+COMPONENT_SUMMARY=      VirtualBox - Host drivers


COMPONENT_SUMMARY should be fixed

pyhalov · 2018-12-05T16:35:08Z

Symbol relocation issue with qt5 is an issue with qt5/suid application. Briefly - for suid application to respect RUNPATH, it shouldn't contain $ORIGIN.

VirtualBox: initial prototype for VirtualBox drivers

5a991e4

alarcher force-pushed the virtualbox branch 2 times, most recently from cb416d9 to afa1853 Compare November 1, 2018 04:40

alarcher force-pushed the virtualbox branch 2 times, most recently from 96eed1e to 7f43522 Compare November 13, 2018 18:45

virtualbox: package version 5.2.22

e3d92fa

alarcher force-pushed the virtualbox branch from 7f43522 to e3d92fa Compare November 13, 2018 18:49

alarcher changed the title ~~[WIP] Virtualbox~~ Virtualbox 5.2.22 Nov 13, 2018

pyhalov reviewed Nov 13, 2018

View reviewed changes

pyhalov reviewed Dec 5, 2018

View reviewed changes

components/sysutils/virtualbox/Makefile Outdated Show resolved Hide resolved

pyhalov reviewed Dec 5, 2018

View reviewed changes

components/sysutils/virtualbox/Makefile Outdated Show resolved Hide resolved

pyhalov added 3 commits December 5, 2018 09:47

virtualbox: fix qt5 paths

e90587d

virtualbox: fix publish in zone

e78aa8b

virtualbox: make package installable in NGZ

d4be7f9

pyhalov reviewed Dec 5, 2018

View reviewed changes

virtualbox: fix COMPONENT_SUMMARY

ae86fe9

pyhalov added 2 commits December 6, 2018 08:56

virtualbox: manifest fixes

f896a28

virtualbox: remove unused file

2760dc7

virtualbox: add header-audio to REQUIRED_PACKAGES

713cd6c

pyhalov merged commit 7134f97 into OpenIndiana:oi/hipster Dec 6, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Virtualbox 5.2.22 #4569

Virtualbox 5.2.22 #4569

alarcher commented Oct 30, 2018 •

edited

timmooney commented Oct 30, 2018

alarcher commented Oct 30, 2018

alarcher commented Nov 13, 2018

pyhalov Nov 13, 2018

alarcher Nov 15, 2018

pyhalov Nov 13, 2018

pyhalov Nov 13, 2018

alarcher Nov 15, 2018

pyhalov Nov 13, 2018

alarcher Nov 15, 2018

pyhalov Nov 13, 2018

alarcher Nov 15, 2018

pyhalov Nov 15, 2018

alarcher Nov 15, 2018

pyhalov Nov 15, 2018

pyhalov Nov 13, 2018 •

edited

alarcher Nov 15, 2018

alarcher commented Nov 15, 2018

pyhalov commented Dec 5, 2018

pyhalov commented Dec 5, 2018

pyhalov Dec 5, 2018

pyhalov commented Dec 5, 2018

		@@ -22,6 +22,111 @@ set name=org.opensolaris.consolidation value=$(CONSOLIDATION)

		license $(COMPONENT_LICENSE_FILE) license='$(COMPONENT_LICENSE)'

		set name=variant.opensolaris.zone value="global"

Virtualbox 5.2.22 #4569

Virtualbox 5.2.22 #4569

Conversation

alarcher commented Oct 30, 2018 • edited

timmooney commented Oct 30, 2018

alarcher commented Oct 30, 2018

alarcher commented Nov 13, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pyhalov Nov 13, 2018 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alarcher commented Nov 15, 2018

pyhalov commented Dec 5, 2018

pyhalov commented Dec 5, 2018

Choose a reason for hiding this comment

pyhalov commented Dec 5, 2018

alarcher commented Oct 30, 2018 •

edited

pyhalov Nov 13, 2018 •

edited