Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vim to 8.1.1526, GTK3, 64-bit, and /etc/vimrc #5062

Merged
merged 2 commits into from Jul 20, 2019

Conversation

Mno-hime
Copy link
Contributor

@Mno-hime Mno-hime commented Jun 6, 2019

Due to security stuff reported by @AndWac: https://github.com/numirias/security/blob/master/doc/2019-06-04_ace-vim-neovim.md.

Ported to GTK 3, 64-bit, added global /etc/vimrc with changes requested at 10342 which make console experience much better.

As Ruby support requires 64-bit Ruby, which we don't have, I disabled it.

@Mno-hime
Copy link
Contributor Author

Mno-hime commented Jun 6, 2019

@Mno-hime Mno-hime changed the title Update vim to 8.1.1471 Update vim to 8.1.1526 Jun 14, 2019
@Mno-hime Mno-hime force-pushed the vim_8.1.1471 branch 2 times, most recently from fb0189b to 1fb467b Compare June 14, 2019 19:34
@Mno-hime Mno-hime changed the title Update vim to 8.1.1526 Update vim to 8.1.1526, GTK3 Jun 14, 2019
@Mno-hime Mno-hime requested a review from pyhalov June 14, 2019 19:36
@Mno-hime Mno-hime changed the title Update vim to 8.1.1526, GTK3 Update vim to 8.1.1526, GTK3, 64-bit, and /etc/vimrc Jun 16, 2019
@alarcher
Copy link
Contributor

Should I merge?

@Mno-hime
Copy link
Contributor Author

It's slightly controversial as it disables Ruby support (or something). I'll rather ask on discuss ml.

@pyhalov
Copy link
Contributor

pyhalov commented Jul 17, 2019

You should be able to enable ruby support now in 64-bit version.

@Mno-hime
Copy link
Contributor Author

Thanks, it builds ruby-26. One thing I should add to the default vimrc is set mouse=, so mouse click does not enter to insert mode, but didn't have luck with it so far, though it works fine on vim's : "command line".

@@ -0,0 +1,34 @@
ko.po: warning: Charset "EUC-KR" is not supported. gmsgfmt relies on iconv(),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we open illumos-gate issue?

@pyhalov
Copy link
Contributor

pyhalov commented Jul 19, 2019

test target is broken:
$ gmake clean test pre-publish
make[3]: *** No rule to make target 'zh_CN.ck', needed by 'check'. Stop

@Mno-hime

@pyhalov pyhalov merged commit 1237586 into OpenIndiana:oi/hipster Jul 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants