userland-mangler: avoid broken packages #6420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndWac
reviewed
Jan 14, 2021
| shutil.copy2(src, dest) | ||
| # Create a copy to mangle | ||
| # Earlier the code would check that the destination file doe not exist | ||
| # yet, however internal library versioning can be different while the |
AndWac
reviewed
Jan 14, 2021
| # When publishing from a non-clean prototype directory older libraries | ||
| # which may be ABI incompatible would then be republished in the new | ||
| # package instead of the new version. | ||
| shutil.copy2(src, dest) | ||
|
|
There was a problem hiding this comment.
The code looks reasonable. But I am neither familiar with the userland-mangler nor a vivid python developer.
Maybe we should try to create some test cases to check it.
… when published from non-clean prototype area
alarcher
force-pushed
the
userland-mangler
branch
from
7c60ca6
to
9463918
Compare
|
LGTM. I don't know about the process details but from what you told me the code looks as it should. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.