Cmake

[erwinlem]

Fixes for cmake.mk, related to #8552.

[Toasterson]

We have LDFLAGS and PKG_CONFIG_PATH now twice in env.
The Original Idea was that they are in env and command so cmake actually picks one because it was inconsistent which it picked. If they have not been added to your build env then thats another bug.

Library architecture looks good. Please leave LDFLAGS and PKG_CONFIG_PATH be for now. We have to look at that seperately.

(cd /ws/toasty/oi-userland/components/shell/fish/build/amd64 ; /usr/bin/env CONFIG_SHELL="/bin/bash" \
CC="/usr/gcc/7/bin/gcc" CXX="/usr/gcc/7/bin/g++" F77="/usr/gcc/7/bin/gfortran" FC="/usr/gcc/7/bin/gfortran"\
 CFLAGS="-m64 -O3 " CXXFLAGS=" -m64 -O3 " FFLAGS=" -m64 -O3 " FCFLAGS="-m64 -O3 "\
 LDFLAGS="-m64" PKG_CONFIG_PATH="/usr/openssl/1.0/lib/64/pkgconfig:/usr/lib/amd64/pkgconfig:/usr/lib/pkgconfig" LDFLAGS="-m64" PKG_CONFIG_PATH="/usr/openssl/1.0/lib/64/pkgconfig:/usr/lib/amd64/pkgconfig:/usr/lib/pkgconfig"  \
        cmake -DCMAKE_C_COMPILER:STRING="/usr/gcc/7/bin/gcc" -DCMAKE_CXX_COMPILER:STRING="/usr/gcc/7/bin/g++" -DCMAKE_Fortran_COMPILER:STRING="/usr/gcc/7/bin/gfortran" -DCMAKE_C_FLAGS:STRING="-m64 -O3 " -DCMAKE_CXX_FLAGS:STRING=" -m64 -O3 " -DCMAKE_Fortran_FLAGS:STRING="-m64 -O3 " -DCMAKE_INSTALL_PREFIX:PATH=/usr -DCMAKE_INSTALL_BINDIR:PATH=bin -DCMAKE_INSTALL_LIBDIR:PATH=lib/amd64 -DCMAKE_INSTALL_SBINDIR:PATH=sbin -DCMAKE_INSTALL_DATAROOTDIR:PATH=share -DCMAKE_INSTALL_DATADIR:PATH=share -DCMAKE_INSTALL_INFODIR:PATH=share/info -DCMAKE_INSTALL_LOCALEDIR:PATH=share/locale -DCMAKE_INSTALL_MANDIR:PATH=share/man -DLIBEXEC_INSTALL_DIR="/usr/lib/amd64" -DLIB_INSTALL_DIR="/usr/lib/amd64" -DCMAKE_LIBRARY_ARCHITECTURE=amd64 -DLIB_SUFFIX="/amd64" -DCMAKE_INSTALL_SYSCONFDIR="/etc" -DPCRE2_INCLUDE_DIR=/usr/include/pcre /ws/toasty/oi-userland/components/shell/fish/fish-3.5.0)

[Toasterson]

LDFLAGS/PKG_CONFIG_PATH get added to CMAKE_ENV on line 98 and 99 not needed here

[erwinlem]

I removed the LDFLAGS commit, that only generated warnings and does not break anything.

[alarcher]

Passing LDFLAGS and PKG_CONFIG_PATH as options is incorrect, Line 13à and 131 need be removed.

[AndWac]

Am 15.07.22 um 17:37 schrieb Aurélien Larcher:

***@***.**** commented on this pull request. Passing LDFLAGS and PKG_CONFIG_PATH as options is incorrect, Line 13à and 131 need be removed. — Reply to this email directly, view it on GitHub <#8605 (review)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ADET4N54OS3TY7OOZBKIRXLVUGAVDANCNFSM53FH3OVQ>. You are receiving this because you modified the open/close state.Message ID: ***@***.***>

The only change in the PR that has been merged was CMAKE_OPTIONS.64 += -DCMAKE_LIBRARY_ARCHITECTURE=amd64