Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Pref Window opening and view/remove button #253

Merged
merged 12 commits into from
Jul 4, 2024

Conversation

Zyvoxi
Copy link
Contributor

@Zyvoxi Zyvoxi commented Jul 2, 2024

Fixed the Pref Window opening and the view/remove button that were not working in version 1.5.0 Alpha.

Copy link
Collaborator

@williambj1 williambj1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! Please address each comment and remove unnecessary changes (newlines, trailing whitespaces).

@Zyvoxi
Copy link
Contributor Author

Zyvoxi commented Jul 2, 2024

@williambj1 I believe that's everything; the pull request is ready to be merged.

@Zyvoxi Zyvoxi changed the title Fixed Pref Window and view/remove button Fixed Pref Window opening and view/remove button Jul 2, 2024
@Zyvoxi Zyvoxi requested a review from williambj1 July 2, 2024 19:09
HeliPort/Appearance/StatusMenu.swift Outdated Show resolved Hide resolved
@Zyvoxi Zyvoxi requested a review from williambj1 July 3, 2024 11:40
@Zyvoxi
Copy link
Contributor Author

Zyvoxi commented Jul 3, 2024

Ready for review and merge

@williambj1 williambj1 merged commit d3d801b into OpenIntelWireless:master Jul 4, 2024
1 check passed
@williambj1 williambj1 added the bug Something isn't working label Jul 4, 2024
@Zyvoxi Zyvoxi deleted the patch-2 branch July 4, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants