Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update local profile so it doen't use function calling #1213

Merged
merged 2 commits into from Apr 24, 2024

Conversation

Notnaton
Copy link
Collaborator

@Notnaton Notnaton commented Apr 19, 2024

leaving model = gpt4 will result in function calling.
Most LM Studio models dont use function calling. making it not work

Describe the changes you have made:

Reference any relevant issues (e.g. "Fixes #000"):

Pre-Submission Checklist (optional but appreciated):

  • I have included relevant documentation updates (stored in /docs)
  • I have read docs/CONTRIBUTING.md
  • I have read docs/ROADMAP.md

OS Tests (optional but appreciated):

  • Tested on Windows
  • Tested on MacOS
  • Tested on Linux

leaving model = gpt4 will result in function calling.
Most LM Studio models dont use functioncalling
@Notnaton Notnaton changed the title Update model so it doen't use function calling Update local profile so it doen't use function calling Apr 21, 2024
@KillianLucas KillianLucas merged commit 9a44661 into OpenInterpreter:main Apr 24, 2024
@KillianLucas
Copy link
Collaborator

Excellent catch, that shouldn't have worked at all before. I changed it to just turn off function calling, which I think makes more sense, but let me know if it's better to change the model instead for any reason. Merged, great work @Notnaton!

@Notnaton
Copy link
Collaborator Author

This works too, but changing the model name would be preferred because I'm making another PR to get context length from the model name.

I'll bring the change in the other PR. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants