Refactor: Add more types and check step in the pipeline #297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zya
force-pushed
the
add-type-hints-v1
branch
from
e8fe336
to
a5b31bb
Compare
zya
force-pushed
the
add-type-hints-v1
branch
2 times, most recently
from
8a198fb
to
b2fb44d
Compare
zya
force-pushed
the
add-type-hints-v1
branch
from
b2fb44d
to
6cc2427
Compare
|
Added more types. Unit tests work fine too. @codeacme17 @KillianLucas |
|
Hi @zya, I've read your changes, and I believe it's a great start for the refactoring project! |
@codeacme17 Thanks. Do you have approval or merge permissions? What is the process for getting this merged? |
|
@zya, sry bro, I am currently just a contributor to this project and don't have merge permissions. You might want to wait for an administrator to handle the merge. |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I personally think this step is a good prep for the refactor to begin. As there are not many tests, adding type hints before refactoring will help folks understand the code and refactor easier.
What do folks think?