Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete GPU implementation #387

Merged
merged 3 commits into from
Aug 9, 2023
Merged

delete GPU implementation #387

merged 3 commits into from
Aug 9, 2023

Conversation

j-i-k-o
Copy link
Collaborator

@j-i-k-o j-i-k-o commented Aug 9, 2023

Changes

  • delete the USE_CUDA section as the GPU algorithm is no longer supported.
  • delete GPU code from python

Destructive changes

  • This PR affects the existing codes using GPU algorithms. Note that these changes do not affect the practical use of OpenJij since the GPU algorithm is no longer supported (current GPU implementation is only for specific graph topology and cannot overperform CPU implementation).

@j-i-k-o j-i-k-o requested a review from 29rou August 9, 2023 01:50
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

Merging #387 (abffd2a) into main (7fefc56) will increase coverage by 1.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #387      +/-   ##
==========================================
+ Coverage   70.53%   72.38%   +1.84%     
==========================================
  Files          46       42       -4     
  Lines        2671     2567     -104     
  Branches      977      925      -52     
==========================================
- Hits         1884     1858      -26     
+ Misses        501      423      -78     
  Partials      286      286              
Flag Coverage Δ
cxxopenjij 68.24% <ø> (ø)
openjij 67.30% <0.00%> (+3.82%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
openjij/model/chimera_model.py 28.34% <0.00%> (+0.65%) ⬆️
openjij/model/model.py 92.28% <ø> (-0.05%) ⬇️

... and 1 file with indirect coverage changes

@codeclimate
Copy link

codeclimate bot commented Aug 9, 2023

Code Climate has analyzed commit abffd2a and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 0.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.7% (4.6% change).

View more on Code Climate.

@yuyamashiro yuyamashiro merged commit f9b731e into main Aug 9, 2023
22 checks passed
@yuyamashiro yuyamashiro deleted the feature/disable_gpu branch August 9, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants