Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[新バージョン対応] 巡回セールスマン問題 #421

Merged
merged 5 commits into from
Apr 10, 2024
Merged

Conversation

github-nakasho
Copy link
Collaborator

Changes

巡回セールスマン問題を用いたOpenJijチュートリアル文章を、新しいバージョンのJijModelingとJijModelingTranspilerに対応させました。

Related issue

https://github.com/Jij-Inc/JijZeptIssues/issues/191

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.09%. Comparing base (45c5703) to head (11b6685).

❗ Current head 11b6685 differs from pull request most recent head ee2b045. Consider uploading reports for the commit ee2b045 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #421   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          42       42           
  Lines        2567     2567           
  Branches      925      925           
=======================================
  Hits         1902     1902           
  Misses        379      379           
  Partials      286      286           
Flag Coverage Δ
openjij 67.46% <ø> (+0.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@NY57 NY57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2024/3/25 14:00 JST時点でのレビューを行いました。
3点ほど、ご修正頂きたい点がありましたので、ご確認よろしくお願いします!

Requirement already satisfied: networkx>=2.4.0 in /home/nakasho/.venv/lib/python3.9/site-packages (from dwave-samplers<2.0.0,>=1.0.0->dwave-neal>=0.5.7->pyqubo->jijmodeling-transpiler) (3.1)

[notice] A new release of pip is available: 23.3.2 -> 24.0
[notice] To update, run: pip install --upgrade pip
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

上記のログ出力で、中村さんの環境が表示されてしまっており、適切ではないと思われる為、
ログ部分をクリアしたものをmarkdownに変換して頂いた方が良いと考えます。

docs/tutorial/ja/003-jijmodeling_openjij_tsp.md Outdated Show resolved Hide resolved
docs/tutorial/ja/003-jijmodeling_openjij_tsp.md Outdated Show resolved Hide resolved
Copy link

codeclimate bot commented Apr 9, 2024

Code Climate has analyzed commit 11b6685 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 60.2% (0.0% change).

View more on Code Climate.

Copy link
Contributor

@NY57 NY57 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

出力画像で不要となっていたものを削除し、mainをpull&mergeしてPR対象外のファイルの差分を消しておきました。PR対象のファイルについては問題ないのでApproveさせて頂きます!

@NY57 NY57 merged commit 4c08057 into main Apr 10, 2024
3 checks passed
@NY57 NY57 deleted the feature/tsp branch April 10, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants