-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[新バージョン対応] 巡回セールスマン問題 #421
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #421 +/- ##
=======================================
Coverage 74.09% 74.09%
=======================================
Files 42 42
Lines 2567 2567
Branches 925 925
=======================================
Hits 1902 1902
Misses 379 379
Partials 286 286
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2024/3/25 14:00 JST時点でのレビューを行いました。
3点ほど、ご修正頂きたい点がありましたので、ご確認よろしくお願いします!
Requirement already satisfied: networkx>=2.4.0 in /home/nakasho/.venv/lib/python3.9/site-packages (from dwave-samplers<2.0.0,>=1.0.0->dwave-neal>=0.5.7->pyqubo->jijmodeling-transpiler) (3.1) | ||
|
||
[1m[[0m[34;49mnotice[0m[1;39;49m][0m[39;49m A new release of pip is available: [0m[31;49m23.3.2[0m[39;49m -> [0m[32;49m24.0[0m | ||
[1m[[0m[34;49mnotice[0m[1;39;49m][0m[39;49m To update, run: [0m[32;49mpip install --upgrade pip[0m |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
上記のログ出力で、中村さんの環境が表示されてしまっており、適切ではないと思われる為、
ログ部分をクリアしたものをmarkdownに変換して頂いた方が良いと考えます。
Code Climate has analyzed commit 11b6685 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 60.2% (0.0% change). View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
出力画像で不要となっていたものを削除し、mainをpull&mergeしてPR対象外のファイルの差分を消しておきました。PR対象のファイルについては問題ないのでApproveさせて頂きます!
Changes
巡回セールスマン問題を用いたOpenJijチュートリアル文章を、新しいバージョンのJijModelingとJijModelingTranspilerに対応させました。
Related issue
https://github.com/Jij-Inc/JijZeptIssues/issues/191