Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ChimeraModel() fails due to missing positional argument 'sparse' #381 #433

Merged
merged 8 commits into from
Jun 21, 2024

Conversation

durga0201
Copy link
Contributor

Changes

added sparse arguement where its needed

Related issue

Sample code

from openjij.model.chimera_model import ChimeraModel
Q={(0, 4): -1, (4, 12): -1}
chimera_model = ChimeraModel(quadratic =Q, unit_num_L=2)
chimera_model.validate_chimera(chimera_model)

Misc

Added dimod types Vartype, SPIN and BINARY as well

@29rou 29rou requested a review from j-i-k-o June 18, 2024 23:03
@29rou 29rou requested a review from K-Suzuki-Jij June 18, 2024 23:08
@29rou 29rou added the bug Something isn't working label Jun 18, 2024
@29rou 29rou linked an issue Jun 18, 2024 that may be closed by this pull request
@29rou 29rou removed the bug Something isn't working label Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 74.09%. Comparing base (b405fd2) to head (5ac7b78).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #433   +/-   ##
=======================================
  Coverage   74.09%   74.09%           
=======================================
  Files          42       42           
  Lines        2567     2567           
  Branches      925      925           
=======================================
  Hits         1902     1902           
  Misses        379      379           
  Partials      286      286           
Flag Coverage Δ
openjij 67.54% <66.66%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
openjij/sampler/csqa_sampler.py 29.72% <ø> (ø)
openjij/utils/benchmark.py 97.43% <ø> (ø)
openjij/model/chimera_model.py 49.60% <66.66%> (ø)

@durga0201
Copy link
Contributor Author

@29rou test cases care getting failed even for main branch on macos-latest and windows-latest.
Screenshot 2024-06-19 at 5 41 42 PM

@29rou
Copy link
Member

29rou commented Jun 20, 2024

Thank you for the pull request. We have fixed the GitHub Actions script, so we apologize for the inconvenience. We would like to kindly request that you run the test again.

@29rou test cases care getting failed even for main branch on macos-latest and windows-latest. Screenshot 2024-06-19 at 5 41 42 PM

@29rou 29rou self-requested a review June 20, 2024 06:08
@29rou 29rou self-assigned this Jun 20, 2024
@j-i-k-o j-i-k-o merged commit 1ebe26c into OpenJij:main Jun 21, 2024
25 checks passed
@durga0201 durga0201 deleted the durga-devlopment branch June 21, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ChimeraModel() fails due to missing positional argument 'sparse'
3 participants