Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Python 3.5 #117

Closed
PeterHamilton opened this issue Jan 5, 2016 · 3 comments
Closed

Add support for Python 3.5 #117

PeterHamilton opened this issue Jan 5, 2016 · 3 comments

Comments

@PeterHamilton
Copy link
Contributor

With the recent release of Python 3.5, many Python developers are upgrading to a version of Python not officially supported by PyKMIP. Since PyKMIP already supports Python 3.3 and 3.4, adding official support for 3.5 should be trivial.

@rellerreller
Copy link
Contributor

I hope it's trivial. 👍

@PeterHamilton
Copy link
Contributor Author

Unfortunately it's not. It took me a little while to trace the issue but there's a weird error that occurs when you attempt to run py35 in tox when you have enum34 installed in older versions of Python. It has something to do how virtualenv works internally, which tox uses. Lots of nastiness.

This was the initial issue on the problem last year: pypa/virtualenv#763. It was supposed to be fixed, so either the issue's reappeared or I'm not doing the right thing in the right way. Apparently there's an ongoing effort to rewrite the bulk of virtualenv to play nice with different interpreters/platforms/environments/etc, so that may fix things eventually.

It also turns out that Travis has had/has issues with 3.5: travis-ci/travis-ci#4794.

Needless to say, there are issues with just adding 3.5 support. I'm leaving this issue open for now, as a todo, but I won't address it for a while.

@PeterHamilton
Copy link
Contributor Author

I added Python 3.5 support with PR #203, so this is done now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants