OpenNI2 driver cleaned up #523
Conversation
|
This should be merged pretty soon after the required testing. |
From libfreenect 89f77f6d2c23876936af65766a4c140898bc3ea8
Test with /opt/OpenNI2/Tools/NiViewer.
|
v2: Add a Tested with NiViewer2. Did not test with pcl_openni2_viewer because it is not packaged. Still needs Windows testing. |
|
@hanyazou
I found these problems exist in the original code, so they are not your problems. |
|
@hanyazou Can you provide some instructions on where and how to install the built libfreenect2-openni2.dylib on Mac OSX? |
|
v3: Fixed MSVC FTBFS. Added Windows installation instructions. TODO: think through proper Linux and MacOSX installation instructions. Because substantial amount of code is changed, this needs retesting on Linux and Mac OSX. |
I believe $OPENNI2_REDIST/OpenNI2/Drivers/ is the driver repository. While /usr/local/lib/ni2/OpenNI.ini might be able to specify the repository path, the default is OpenNI2/Drivers/. You should install the library to the default driver repository path. |
|
v4:
|
|
@hanyazou How does this work on Mac OSX now? |
|
@xlz it seems not to work. The .dylib is installed to /usr/local/lib/openni2/. Please refer full build and test log attached. |
Have you done that? |
|
@xlz 'make install-openni2' copies libfreenect2-openni2.dylib into /usr/local/lib/ni2/OpenNI2/Drivers/ and the NiViewer works fine! |
make install to copy libfreenect2-openni2* to lib/OpenNI2/Drivers. make install-openni2 to cmake -E copy_directory OpenNI2/Drivers
@HenningJ has the following contribution to this commit: Change copying of color images to reflect the change from BGR to BGRX color format.
|
One last change (v5): I'll test this on linux and windows on Monday. If eveything is already, I'll merge this then. |
|
Tests OK on Linux and Windows. |
|
I'm trying to convert an image from openni::VideoFrameRef to cv::Mat. http://stackoverflow.com/questions/15966722/capture-rgb-from-kinnect-with-openni-and-show-with-opencv When I start the program SimpleRead of Openni2, the depth image looks very good. I would appreciate any suggestions or ideas to solve this problem. |
|
@hanyazou is responsible to OpenNI2 related questions. |
|
I have followed the windows instructions. Every thing is ok except I can not find any file named "libfreenect2-openni2.dll". |
|
Post output of the CMake configure log. |
|
The C compiler identification is MSVC 18.0.31101.0 |
|
Post a list of all files recursively under the build directory. |
|
│ ALL_BUILD.vcxproj |
|
If you followed the instructions, there would not be "MinSizeRel". |
|
|
|
I had a try on another computer today, but still no "libfreenect2-openni2.dll" :( |
|
What error? If you don't follow the instructions, you are expected to be capable to follow and debug the script in spirit and not ask question here. |
|
Hello, I am trying to use Kinect v2 to build applications on linux to detect and track skeleton, using libfreenect2. thanks |
|
@mennayahia It it not so difficult. Read README.md on the top page https://github.com/OpenKinect/libfreenect2 and follow the instruction https://github.com/OpenKinect/libfreenect2#linux to install. |
|
@hanyazou Thanks for the help. |
|
@mennayahia Are you looking for a skeleton tracking library? This project libfreenect2 nor OpenNI2 does not contain any skeleton tracking function. You might be able to use the Nite binary for that purpose. Refer #243. |
|
@hanyazou |
|
@mennayahia |
|
But keep in mind that you are not actually allowed to do that, since you are only allowed to use NiTE with Primesense devices. |
|
@HenningJ @mennayahia |
|
But does Skeltrack works with kinect v2 ? |
|
someone made it work with Kinect v2: joaquimrocha/Skeltrack#28 |
|
@hanyazou Thanks |
Cleaned up from #518. Previous PR #302. Discussion #243.
Build tested on Debian. Tested on MacOSX.
Still need Windows testing, and docs for installation on Windows.