Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 'based' to stopwords #349

Merged
merged 1 commit into from
Mar 29, 2019
Merged

added 'based' to stopwords #349

merged 1 commit into from
Mar 29, 2019

Conversation

chreman
Copy link
Member

@chreman chreman commented Mar 22, 2019

This PR fixes #266 by adding "based" to the stopwords-list.

Improvements can be seen by searching for "based" in both PubMed and BASE.

@chreman chreman requested a review from pkraker March 22, 2019 11:15
@pkraker pkraker requested a review from tanteuschi March 28, 2019 19:58
Copy link
Collaborator

@tanteuschi tanteuschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for "algorithm design" in Base and "based" in Pubmed. Unfortunately it didn't work for "based" in Base: I found different selection of papers when comparing both maps - this needs to be investigated before merge. Expected outcome: same papers within both maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prevent labels from starting or ending in "based"
3 participants