Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(theme): add new style for compomponent Input #269

Merged
merged 4 commits into from
May 10, 2024
Merged

feat(theme): add new style for compomponent Input #269

merged 4 commits into from
May 10, 2024

Conversation

gerzon05
Copy link
Collaborator

No description provided.

@gerzon05 gerzon05 added react This label for the package of react feat New feature or request theme This label for the package theme labels May 10, 2024
@gerzon05 gerzon05 added this to the v2.0.0 milestone May 10, 2024
Copy link

cloudflare-pages bot commented May 10, 2024

Deploying openui with  Cloudflare Pages  Cloudflare Pages

Latest commit: 824094d
Status: ✅  Deploy successful!
Preview URL: https://4ec20f35.openui-dd0.pages.dev
Branch Preview URL: https://input.openui-dd0.pages.dev

View logs

@sebastiandotdev
Copy link
Collaborator

sebastiandotdev commented May 10, 2024

Obtengo este error desde cloudflare


Failed to compile.

13:22:42.741 | ▲  ../../packages/components/react/input/input.tsx:6:18
13:22:42.741 | ▲  Type error: Interface 'Props' cannot simultaneously extend types 'InputHTMLAttributes<HTMLInputElement>' and 'VariantProps<(props?: ({ borderColor?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; background?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; size?: "small" \| ... 3 more ... \| undefined; } & ClassProp) \| undefined) => string>'.
13:22:42.741 | ▲  Named property 'size' of types 'InputHTMLAttributes<HTMLInputElement>' and 'VariantProps<(props?: ({ borderColor?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; background?: "error" \| "none" \| "primary" \| "success" \| "warn" \| null \| undefined; size?: "small" \| ... 3 more ... \| undefined; } & ClassProp) \| undefined) => string>' are not identical.
13:22:42.742 | ▲
13:22:42.742 | ▲    4 \|
13:22:42.742 | ▲    5 \| export interface Comp extends HTMLInputElement {}
13:22:42.742 | ▲  > 6 \| export interface Props extends React.InputHTMLAttributes<HTMLInputElement>,
13:22:42.742 | ▲      \|                  ^
13:22:42.742 | ▲    7 \|   VariantProps <typeof input> {
13:22:42.742 | ▲    8 \|   Label?: string
13:22:42.742 | ▲    9 \|   Icon?: React.ReactNode
13:22:42.832 | ▲  ELIFECYCLE  Command failed with exit code 1.
13:22:42.871 | ▲  Error: Command "pnpm run build" exited with 1
13:22:42.959 |  
13:22:42.960 | ⚡️ The Vercel build (`npx vercel build`) command failed. For more details see the Vercel logs above.
13:22:42.960 | ⚡️ If you need help solving the issue, refer to the Vercel or Next.js documentation or their repositories.
13:22:42.960 |  
13:22:42.996 | Failed: Error while executing user command. Exited with error code: 1
13:22:43.008 | Failed: build command exited with code: 1
13:22:44.366 | Failed: error occurred while running build command

@gerzon05 gerzon05 enabled auto-merge (squash) May 10, 2024 19:08
packages/components/react/input/input.tsx Outdated Show resolved Hide resolved
packages/components/react/input/input.tsx Outdated Show resolved Hide resolved
packages/theme/src/components/input.ts Outdated Show resolved Hide resolved
packages/theme/src/components/input.ts Outdated Show resolved Hide resolved
packages/components/react/input/input.tsx Outdated Show resolved Hide resolved
@gerzon05 gerzon05 merged commit 6afce87 into main May 10, 2024
2 checks passed
@gerzon05 gerzon05 deleted the Input branch May 10, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request react This label for the package of react theme This label for the package theme
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants