Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Firebase #77

Merged
merged 5 commits into from Dec 22, 2022
Merged

Integrated Firebase #77

merged 5 commits into from Dec 22, 2022

Conversation

ken1000minus7
Copy link
Contributor

Related Issue

Not related to any

Proposed Changes

  • Integrated firebase
  • Saved the user data in firebase
  • Bumped dependencies and changed target sdk to match the new requirement of the dependencies
  • Cleaned up code in various places
  • Changed authentication screen to accommodate register and login
  • Setup authentication using firebase
  • Remove old authentication implementation

Additional Info

  • I hv changed the user entity properties a bit due to which I hv used null in various places, all these will be removed as I will completely remove user room database
  • Along with removing user room database, a few changes will be made in the profile page as well to accommodate firebase firestore

Checklist

  • βœ… My code follows the code style of this project.
  • πŸ“ My change requires a change to the documentation.
  • πŸŽ€ I have updated the documentation accordingly.
  • πŸ‘€ I have read the CONTRIBUTING document.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@yellowHatpro yellowHatpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!!

@yellowHatpro yellowHatpro merged commit 37ce635 into OpenLake:main Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants