Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced room database with firebase of user #78

Merged
merged 4 commits into from Dec 25, 2022

Conversation

ken1000minus7
Copy link
Contributor

Related Issue

No issue

Proposed Changes

  • Removed all the files related to the room implementation for storing user data
  • Changed profile page
  • Replaced profile info from room with that from firebase
  • Cleaned up code a bit
  • Cached user data using shared preferences

Additional Info

None

Checklist

  • βœ… My code follows the code style of this project.
  • πŸ“ My change requires a change to the documentation.
  • πŸŽ€ I have updated the documentation accordingly.
  • πŸ‘€ I have read the CONTRIBUTING document.
  • 🌟 ed the repo
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Collaborator

@yellowHatpro yellowHatpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

later for shared prefs we will go with a new file that will contain all shared prefs with getters and setters, for now its fine.

Copy link
Collaborator

@yellowHatpro yellowHatpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great! lgtm . πŸ‘Œ

@yellowHatpro yellowHatpro merged commit 6bc2ba2 into OpenLake:main Dec 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants