New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification feature #23

Merged

Ash-KODES merged 4 commits into OpenLake:main from Shrey-Raj:notification-feature

Feb 1, 2024

Contributor

Shrey-Raj commented Jan 31, 2024 •

edited

Added the notification feature , to notify the members about the entry or exit of a client(member)

The changes made are self explanatory , I believe . Nevertheless a quick recap :

./server/index.js : emit event 'send-notification' wherever it is required
./script/background.js : Added the listener for the 'send-notification' socket event and thereby creating a notification for the corresponding message.
manifest.json : included the 'notifications' permission
./server/utils/room.js : fixed the 'getHostName' function as it was halting the code flow due to a minute error

Shrey-Raj added 4 commits

January 31, 2024 22:05


          Update background.js : add listener for socket event

b1f83ae


          Update manifest.json : add 'notifications' permission

01841af


          Update index.js : emit socket event for sending notification

306cf57


          Update room.js : fixed the 'getHostName' function

3f6b94d

Collaborator

Ash-KODES commented Feb 1, 2024

LGTM great work!

Ash-KODES merged commit 26be4ab into OpenLake:main

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment